CELE-148 Fix missing await for async workspace creation#111
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a missing await for async workspace creation and adds optional chaining for safe property access. The main issue addressed is ensuring that the createWorkspace function is properly awaited when called from UI components.
- Added optional chaining to prevent potential null/undefined access errors
- Updated function signature to properly reflect async nature
- Added await to async workspace creation call
- Minor UI layout adjustments for better flex display
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| workspace.ts | Added optional chaining for safe property access on firstActiveDataset |
| GlobalContext.tsx | Updated createWorkspace function signature to return Promise<void> |
| CreateNewWorkspaceDialog.tsx | Made handleSubmit async and added await to createWorkspace call |
| DataSets.tsx | Updated layout styling with flex display and removed fixed height constraint |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.