CELE-144 Fix synapses that are not removed after the deletion of a related Neuron

applications/visualizer/frontend/src/components/ViewerContainer/Neurons.tsx

@@ -57,7 +57,8 @@ const Neurons = ({ children }) => {
     }
   };
   const handleDeleteNeuron = (neuronId: string) => {
-    currentWorkspace.deactivateNeuron(neuronId);
+    const workspace = currentWorkspace.deactivateSynapsesOfNeuron(neuronId);
+    workspace.deactivateNeuron(neuronId);
   };
 
   const onSearchNeurons = (nameFragment) => {

applications/visualizer/frontend/src/components/ViewerContainer/SynapsesTreeView.tsx

@@ -155,6 +155,7 @@ export default function BasicRichTreeView() {
     itemVisibilityStates,
     itemColorStates,
     openColorPicker,
+    currentWorkspace.activeSynapses,
   ]);
 
   // Update tree items when dependencies change
@@ -254,7 +255,7 @@ export default function BasicRichTreeView() {
         }
       }
     },
-    [currentWorkspace, treeItems],
+    [currentWorkspace, treeItems, currentWorkspace.visibilities.synapses, currentWorkspace.activeSynapses],
   );
 
   useEffect(() => {
@@ -346,7 +347,7 @@ export default function BasicRichTreeView() {
         );
       },
     }),
-    [handleColorClick, currentWorkspace, handleSynapseVisibilityToggle, treeItems],
+    [handleColorClick, currentWorkspace, handleSynapseVisibilityToggle, treeItems, currentWorkspace.visibilities.synapses, currentWorkspace.activeSynapses],
   );
 
   return (

applications/visualizer/frontend/src/components/ViewerContainer/SynapsesTreeViewHelpers.ts

@@ -18,6 +18,9 @@ export const transformSynapsesToTree = (synapses: any, availableNeurons: any, cu
   // Helper function to get synapse visibility
   const getSynapseVisibility = (synapseId: number): boolean => {
     const synapseVisibility = currentWorkspace.getSynapseVisibility(synapseId);
+    if (!synapseVisibility) {
+      return false;
+    }
     return Object.values(synapseVisibility).every((e: any) => e === undefined || e.visibility === Visibility.Visible);
   };
 

applications/visualizer/frontend/src/models/workspace.ts

@@ -172,6 +172,25 @@ export class Workspace {
     return this;
   }
 
+  @triggerUpdate
+  deactivateSynapsesOfNeuron(neuronId: string) {
+    const neuronClass = this.availableNeurons?.[neuronId]?.nclass;
+    if (!neuronClass) {
+      return this;
+    }
+    const relatedSynapses = this.synapsesData?.synapses[neuronClass];
+    if (!relatedSynapses) {
+      return this;
+    }
+    for (const synapseId of collectLeafProps(relatedSynapses, "id")) {
+      delete this.visibilities.synapses[synapseId];
+      this.activeSynapses.delete(synapseId);
+    }
+    delete this.synapsesData.synapses[neuronClass];
+
+    return this;
+  }
+
   @triggerUpdate
   hideNeuron(neuronId: string) {
     if (!(neuronId in this.visibilities.neurons)) {
@@ -538,3 +557,28 @@ export class Workspace {
     return allSynapses;
   }
 }
+
+function collectLeafProps<T>(obj: unknown, targetProp: keyof T): T[keyof T][] {
+  const results: T[keyof T][] = [];
+
+  function recurse(node: unknown) {
+    if (node == null || typeof node !== "object") return;
+
+    // We collect the target property
+    if (targetProp in (node as object)) {
+      results.push((node as T)[targetProp]);
+    }
+
+    // Traverse every property
+    for (const value of Object.values(node)) {
+      if (Array.isArray(value)) {
+        for (const child of value) recurse(child);
+      } else if (typeof value === "object") {
+        recurse(value);
+      }
+    }
+  }
+
+  recurse(obj);
+  return results;
+}