CELE-144 Fix synapses that are not removed after the deletion of a related Neuron#110
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where synapses were not being properly removed when their related neurons were deleted. The fix ensures that when a neuron is deleted, all associated synapses are also deactivated and cleaned up from the workspace state.
Key changes:
- Added a new method to deactivate synapses when a neuron is deleted
- Updated the neuron deletion handler to clean up related synapses
- Enhanced synapse visibility checking with null safety
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| workspace.ts | Added deactivateSynapsesOfNeuron method and helper function collectLeafProps to clean up synapses when neurons are deleted |
| SynapsesTreeViewHelpers.ts | Added null check for synapse visibility to prevent errors |
| SynapsesTreeView.tsx | Updated useCallback dependencies to include synapse-related state for proper re-rendering |
| Neurons.tsx | Modified delete handler to call synapse cleanup before neuron deletion |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes the issue encoutered by @SimaoBolota-MetaCell for CELE-144