Skip to content

Move some scripts to the framework#10624

Merged
gilles-peskine-arm merged 6 commits into
Mbed-TLS:developmentfrom
gilles-peskine-arm:audit_validity_dates-move-to-framework
Mar 19, 2026
Merged

Move some scripts to the framework#10624
gilles-peskine-arm merged 6 commits into
Mbed-TLS:developmentfrom
gilles-peskine-arm:audit_validity_dates-move-to-framework

Conversation

@gilles-peskine-arm

@gilles-peskine-arm gilles-peskine-arm commented Feb 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  1. Remove the files added to the framework in Move some scripts from mbedtls mbedtls-framework#283.
  2. Adapt build scripts accordingly.

PR checklist

@gilles-peskine-arm gilles-peskine-arm added needs-ci Needs to pass CI tests needs-preceding-pr Requires another PR to be merged first priority-high High priority - will be reviewed soon labels Feb 26, 2026
@gilles-peskine-arm gilles-peskine-arm added the size-xs Estimated task size: extra small (a few hours at most) label Feb 26, 2026
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Feb 26, 2026
Merged
3 tasks
@gilles-peskine-arm gilles-peskine-arm force-pushed the audit_validity_dates-move-to-framework branch 2 times, most recently from 2c3f354 to 0c9b9d1 Compare March 2, 2026 15:39
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review needs-backports Backports are missing or are pending review and approval. needs-preceding-pr Requires another PR to be merged first needs-work and removed needs-work needs-ci Needs to pass CI tests needs-preceding-pr Requires another PR to be merged first needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Mar 2, 2026
@gilles-peskine-arm gilles-peskine-arm force-pushed the audit_validity_dates-move-to-framework branch from 0c9b9d1 to 1fe06c6 Compare March 3, 2026 12:55
@gilles-peskine-arm gilles-peskine-arm changed the title Move some scripts from mbedtls Move some scripts to the framework Mar 3, 2026
@gilles-peskine-arm gilles-peskine-arm added needs-ci Needs to pass CI tests needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-work needs-ci Needs to pass CI tests labels Mar 3, 2026
@gilles-peskine-arm gilles-peskine-arm force-pushed the audit_validity_dates-move-to-framework branch 2 times, most recently from f353e7b to a95fb10 Compare March 9, 2026 09:53
@gilles-peskine-arm
Move some scripts from mbedtls into the framework
326fb18 
Move a bunch of files from `scripts` and `mbedtls/scripts` to the framework.
Most are not called from any scripts invoked by the CI, but a couple are.
A subsequent commit will adapt the scripts. None of these scripts are
referenced from other repositories except in documentation.

The following files will be removed, and added to `mbedtls-framework`:

* `scripts/ecp_comb_table.py`
* `scripts/massif_max.pl`
* `tests/scripts/audit-validity-dates.py` (moved to `scripts/`)
* `tests/scripts/gen_ctr_drbg.pl` (moved to `scripts/`)
* `tests/scripts/gen_gcm_decrypt.pl` (moved to `scripts/`)
* `tests/scripts/gen_gcm_encrypt.pl` (moved to `scripts/`)
* `tests/scripts/gen_pkcs1_v21_sign_verify.pl` (moved to `scripts/`)
* `tests/scripts/generate-afl-tests.sh` (moved to `scripts/`)
* `tests/scripts/generate_server9_bad_saltlen.py` (moved to `scripts/`)
* `tests/scripts/run-metatests.sh` (moved to `scripts/`)
* `tests/scripts/run_demos.py` (moved to `scripts/`)
* `tests/scripts/test_config_script.py` (moved to `scripts/`)

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm
Update framework with moved scripts
702b389 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm
Move requirements to the framework for scripts in the framework
c4d40c2 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm
Update paths after moving some scripts to the framework
f840cb1 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm force-pushed the audit_validity_dates-move-to-framework branch from a95fb10 to f840cb1 Compare March 12, 2026 09:19
@gilles-peskine-arm

gilles-peskine-arm commented Mar 12, 2026

Copy link
Copy Markdown
Contributor Author

I rebased on top of development so that there's no conflict on the framework, and I amended the framework update commit to go to the merge of the prerequisite.

valeriosetti
valeriosetti previously approved these changes Mar 12, 2026
View reviewed changes
bjwtaylor
bjwtaylor reviewed Mar 12, 2026
View reviewed changes
Comment thread scripts/massif_max.pl Outdated

@bjwtaylor bjwtaylor Mar 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this script is still referenced in the scripts/memory.sh:93. I'm not sure if this code is ever executed, though we should probably update it to the new path if it's a file we are still maintaining.

@gilles-peskine-arm
Update massif_max.pl location
931fc8c 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm removed needs-preceding-pr Requires another PR to be merged first needs-reviewer This PR needs someone to pick it up for review labels Mar 12, 2026
@github-project-automation github-project-automation Bot moved this from In Development to Has Approval in Roadmap pull requests (new board) Mar 16, 2026
@gilles-peskine-arm gilles-peskine-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Mar 19, 2026
@gilles-peskine-arm

gilles-peskine-arm commented Mar 19, 2026

Copy link
Copy Markdown
Contributor Author

I'm going ahead and merging this into development, before there's yet another conflict with the framework submodule, even though the 3.6 backport can't be merged yet due to a submodule conflict. Note that it'll also need to go into mbedtls-4.1 once we create the branch.

@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue Mar 19, 2026
Merged via the queue into Mbed-TLS:development with commit 7f4fe39 Mar 19, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Has Approval to Done in Roadmap pull requests (new board) Mar 19, 2026
This was referenced Mar 19, 2026
Merged
Merged
Merged
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Apr 9, 2026
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjwtaylor bjwtaylor bjwtaylor approved these changes

@valeriosetti valeriosetti valeriosetti approved these changes

Assignees

No one assigned

Labels

approved Design and code approved - may be waiting for CI or backports needs-backports Backports are missing or are pending review and approval. priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)

Projects

Roadmap pull requests (new board)
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gilles-peskine-arm @bjwtaylor @valeriosetti