Skip to content

3.6 only: Move some scripts from mbedtls into the framework redux#10658

Merged
gilles-peskine-arm merged 2 commits into
Mbed-TLS:mbedtls-3.6from
gilles-peskine-arm:audit_validity_dates-move-to-framework-3.6-actually-remove-scripts
Apr 9, 2026
Merged

3.6 only: Move some scripts from mbedtls into the framework redux#10658
gilles-peskine-arm merged 2 commits into
Mbed-TLS:mbedtls-3.6from
gilles-peskine-arm:audit_validity_dates-move-to-framework-3.6-actually-remove-scripts

Conversation

@gilles-peskine-arm

@gilles-peskine-arm gilles-peskine-arm commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

In #10629, I forgot to actually remove the files that were added to the framework.

The commit is a cherry-pick of 326fb18 "Move some scripts from mbedtls into the framework" from #10624 with no conflicts, showing that the removed files are identical in 3.6 (thanks to the preliminary work in #10629).

PR checklist

Move a bunch of files from `scripts` and `mbedtls/scripts` to the framework.
Most are not called from any scripts invoked by the CI, but a couple are.
A subsequent commit will adapt the scripts. None of these scripts are
referenced from other repositories except in documentation.

The following files will be removed, and added to `mbedtls-framework`:

* `scripts/ecp_comb_table.py`
* `scripts/massif_max.pl`
* `tests/scripts/audit-validity-dates.py` (moved to `scripts/`)
* `tests/scripts/gen_ctr_drbg.pl` (moved to `scripts/`)
* `tests/scripts/gen_gcm_decrypt.pl` (moved to `scripts/`)
* `tests/scripts/gen_gcm_encrypt.pl` (moved to `scripts/`)
* `tests/scripts/gen_pkcs1_v21_sign_verify.pl` (moved to `scripts/`)
* `tests/scripts/generate-afl-tests.sh` (moved to `scripts/`)
* `tests/scripts/generate_server9_bad_saltlen.py` (moved to `scripts/`)
* `tests/scripts/run-metatests.sh` (moved to `scripts/`)
* `tests/scripts/run_demos.py` (moved to `scripts/`)
* `tests/scripts/test_config_script.py` (moved to `scripts/`)

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) labels Mar 25, 2026

@bjwtaylor bjwtaylor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On small suggestion, let me know what you think though.

Comment thread tests/scripts/run-metatests.sh Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is still referenced in it's current location here docs/architecture/psa-shared-memory.md:685. Is it worth updating this reference path?

@gilles-peskine-arm gilles-peskine-arm Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. That documentation went to crypto in the split, so I'll make a PR to update the path in TF-PSA-Crypto as well. Mbed-TLS/TF-PSA-Crypto#728

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm removed the needs-ci Needs to pass CI tests label Apr 9, 2026
@github-project-automation github-project-automation Bot moved this from In Development to Has Approval in Roadmap pull requests (new board) Apr 9, 2026
@gilles-peskine-arm gilles-peskine-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Apr 9, 2026
@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue Apr 9, 2026
Merged via the queue into Mbed-TLS:mbedtls-3.6 with commit 87eba69 Apr 9, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Has Approval to Done in Roadmap pull requests (new board) Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Design and code approved - may be waiting for CI or backports priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)

Development

Successfully merging this pull request may close these issues.

3 participants