Repository navigation
build: stop enabling reqwest's native-tls - #10
Draft
jasonhernandez wants to merge 1 commit into
Draft
jasonhernandez wants to merge 1 commit into
jasonhernandez wants to merge 1 commit into
Conversation
NOT FOR UPSTREAM. Materialize picks reqwest's TLS backend (rustls with the aws-lc-rs provider) through feature unification, so the fork no longer forces OpenSSL into every consumer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOT FOR UPSTREAM. The workspace
reqwestdependency no longer enablesnative-tls, so the fork sets no TLS backend. Materialize enables reqwest's rustls feature itself and installs the aws-lc-rs provider at process startup. That removesopenssl,native-tlsandhyper-tlsfrom the fork's dependency graph.This reverses the native-tls part of #5. Materialize is moving its TLS clients off OpenSSL, so the old preference no longer applies.
Risks
Built on its own, the fork has no TLS backend, so HTTPS requests from its own tests or tools fail at connect time. Materialize builds are unaffected because they turn on rustls through feature unification.
Tests
cargo check -p iceberg -p iceberg-catalog-restpasses. No code uses native-tls-specific reqwest APIs.🤖 Generated with Claude Code