Repository navigation
deps: use rustls for reqwest 0.12, segment and the iceberg fork - #40834
Draft
jasonhernandez wants to merge 1 commit into
Draft
jasonhernandez wants to merge 1 commit into
jasonhernandez wants to merge 1 commit into
Conversation
reqwest 0.12 now uses rustls with the platform root store and no bundled crypto provider, so it uses the aws-lc-rs provider environmentd and clusterd install at startup. segment no longer enables native-tls, and the iceberg fork rev drops its native-tls feature. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
recheck |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
reqwest 0.12 was the last reqwest in the tree still built on OpenSSL. Three things enabled it: the
reqwest-0-12alias used by the iceberg connection code,segment, and the iceberg fork itself.Description
reqwest-0-12usesrustls-tls-native-roots-no-provider. It trusts the platform root store, like the other TLS clients, and uses the aws-lc-rs provider that environmentd and clusterd install at startup. It does not pull in ring.segmentno longer enablesnative-tls-vendored. It shares the reqwest 0.12 build, so it gets rustls through feature unification.native-tls. This PR points at that branch's commit. Re-point the rev at the merge commit after #10 merges. The fuzz workspace mirrors the same rev.After this, reqwest 0.12 no longer depends on
native-tls,hyper-tlsortokio-native-tls. The remaining native-tls users are tiberius, plus mz-ore and environmentd, which #40145 removes.Risks
-no-provider, building a reqwest 0.12 client panics if no rustls provider is installed. Production clients are built in environmentd (segment) and clusterd/environmentd (iceberg), which both install aws-lc-rs first. No Rust tests build a reqwest 0.12 client.Verification
cargo check -p mz-storage-types -p mz-segmentpasses.cargo treeshows reqwest 0.12 resolving onlyrustls-tls-native-roots-no-providerfor TLS. Pre-push lint, including clippy and cargo-deny, passes. I haven't run iceberg sink tests against a TLS REST catalog locally, so CI is the first run of those.🤖 Generated with Claude Code