Skip to content

deps: use rustls for reqwest 0.12, segment and the iceberg fork - #40834

Draft
jasonhernandez wants to merge 1 commit into
MaterializeInc:mainfrom
jasonhernandez:jason/reqwest-0-12-rustls
Draft

jasonhernandez wants to merge 1 commit into
MaterializeInc:mainfrom
jasonhernandez:jason/reqwest-0-12-rustls

Conversation

@jasonhernandez

Copy link
Copy Markdown
Contributor

Motivation

reqwest 0.12 was the last reqwest in the tree still built on OpenSSL. Three things enabled it: the reqwest-0-12 alias used by the iceberg connection code, segment, and the iceberg fork itself.

Description

  • reqwest-0-12 uses rustls-tls-native-roots-no-provider. It trusts the platform root store, like the other TLS clients, and uses the aws-lc-rs provider that environmentd and clusterd install at startup. It does not pull in ring.
  • segment no longer enables native-tls-vendored. It shares the reqwest 0.12 build, so it gets rustls through feature unification.
  • The iceberg fork moves to build: stop enabling reqwest's native-tls iceberg-rust#10, which stops enabling reqwest's native-tls. This PR points at that branch's commit. Re-point the rev at the merge commit after #10 merges. The fuzz workspace mirrors the same rev.

After this, reqwest 0.12 no longer depends on native-tls, hyper-tls or tokio-native-tls. The remaining native-tls users are tiberius, plus mz-ore and environmentd, which #40145 removes.

Risks

  • With -no-provider, building a reqwest 0.12 client panics if no rustls provider is installed. Production clients are built in environmentd (segment) and clusterd/environmentd (iceberg), which both install aws-lc-rs first. No Rust tests build a reqwest 0.12 client.
  • Iceberg REST catalogs and Segment now verify certificates with rustls instead of OpenSSL. Certificates OpenSSL accepted but rustls/webpki rejects (for example, ones without a SAN) will fail to connect.
  • Rollback is a revert. Nothing persisted changes.

Verification

cargo check -p mz-storage-types -p mz-segment passes. cargo tree shows reqwest 0.12 resolving only rustls-tls-native-roots-no-provider for TLS. Pre-push lint, including clippy and cargo-deny, passes. I haven't run iceberg sink tests against a TLS REST catalog locally, so CI is the first run of those.

🤖 Generated with Claude Code

reqwest 0.12 now uses rustls with the platform root store and no bundled
crypto provider, so it uses the aws-lc-rs provider environmentd and
clusterd install at startup. segment no longer enables native-tls, and the
iceberg fork rev drops its native-tls feature.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jasonhernandez

Copy link
Copy Markdown
Contributor Author

recheck

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant