Skip to content

Point the submodules at the marker click fix and drop CirclePage's workaround #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wf9a5m75 merged 3 commits into from
Nov 9, 2026
Merged

Point the submodules at the marker click fix and drop CirclePage's workaround #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
397a0a1
Point js-sdk-core and react-for-deckgl at the marker click fix
wf9a5m75 Nov 9, 2026
4c390df
CirclePage: drop the circle-click suppression after a marker drag
wf9a5m75 Nov 9, 2026
6f72db9
Point js-sdk-core, react-for-deckgl and react-for-azuremaps at develop
wf9a5m75 Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions examples/basic/src/pages/CirclePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useCallback, useEffect, useMemo, useRef, useState } from 'react';
import { useCallback, useEffect, useMemo, useState } from 'react';
import {
ColorDefaultIcon,
Planar,
Expand All @@ -20,7 +20,6 @@ import { useSampleI18n } from '../samples/i18n';
const CIRCLE_CENTER = createGeoPoint({ latitude: 21.382314, longitude: -157.933097 });
const INIT_CAMERA = { lat: CIRCLE_CENTER.latitude, lng: CIRCLE_CENTER.longitude, zoom: 3 };
const INITIAL_RADIUS_METERS = 5000000.0;
const SUPPRESS_CIRCLE_CLICK_AFTER_MARKER_DRAG_MS = 300;
const CIRCLE_COLORS = ['#0000ff', '#ff0000', '#008000', '#00ffff', '#d3d3d3', '#ff00ff'];

function rgba(hex: string, alpha: number): string {
Expand Down Expand Up @@ -57,7 +56,6 @@ export function CirclePage() {
const [strokeWidth, setStrokeWidth] = useState(3);
const [labelOffset, setLabelOffset] = useState<Offset | null>(null);
const [cameraTick, setCameraTick] = useState(0);
const suppressCircleClickUntilRef = useRef(0);
const { messages, showToast, dismissToast } = useToast();
const radius = useMemo(
() => Spherical.computeDistanceBetween(CIRCLE_CENTER, edgePosition),
Expand Down Expand Up @@ -87,12 +85,6 @@ export function CirclePage() {
setEdgePosition(dragged.position);
}, []);

const handleMarkerDragEnd = useCallback((dragged: MarkerState) => {
suppressCircleClickUntilRef.current =
Date.now() + SUPPRESS_CIRCLE_CLICK_AFTER_MARKER_DRAG_MS;
setEdgePosition(dragged.position);
}, []);

const circleState = useMemo(
() =>
createCircleState({
Expand All @@ -106,7 +98,6 @@ export function CirclePage() {
geodesic: true,
clickable: true,
onClick: () => {
if (Date.now() < suppressCircleClickUntilRef.current) return;
setColorIndex((index) => (index + 1) % CIRCLE_COLORS.length);
showToast(`Circle clicked - Radius: ${radius.toFixed(0)}m`);
},
Expand Down Expand Up @@ -152,7 +143,7 @@ export function CirclePage() {
draggable
onDragStart={handleMarkerMove}
onDrag={handleMarkerMove}
onDragEnd={handleMarkerDragEnd}
onDragEnd={handleMarkerMove}
/>
{labelOffset && (
<div
Expand Down
2 changes: 1 addition & 1 deletion js-sdk-core
Open in desktop
Submodule js-sdk-core updated 4 files
+11 −0 src/controller/AbstractMarkerController.ts
+26 −0 src/controller/BaseMapViewController.ts
+81 −10 src/marker/DefaultMarkerEventController.ts
+267 −0 test/MarkerDragClickLeak.test.mjs
2 changes: 1 addition & 1 deletion react-for-azuremaps
Open in desktop
Submodule react-for-azuremaps updated 8 files
+6 −13 api/react-for-azuremaps.api.d.ts
+7 −7 src/AzureMapsViewController.ts
+49 −7 src/helpers.ts
+57 −52 src/marker/AzureMapsMarkerController.ts
+93 −0 src/marker/AzureMapsMarkerEventController.ts
+6 −3 src/raster/AzureMapsRasterLayer.ts
+9 −5 src/vector/AzureMapsVectorControllers.ts
+297 −0 test/MarkerDragTap.test.mjs
2 changes: 1 addition & 1 deletion react-for-deckgl
Open in desktop
Submodule react-for-deckgl updated 5 files
+10 −1 src/DeckGLMap.ts
+7 −7 src/DeckGLMapViewController.ts
+21 −0 src/marker/markerGestureTap.ts
+6 −1 src/raster/DeckGLRasterLayer.ts
+34 −0 test/MarkerGestureTap.test.mjs
Loading