Repository navigation
Point the submodules at the marker click fix and drop CirclePage's workaround - #48
Merged
Merged
Conversation
js-sdk-core fix/marker-drag-click-leak (a3443c7): the click that ends a marker gesture no longer reaches the map, a tap on a draggable marker is delivered once, and a clickable: false marker passes the tap through to what is under it, as on Android. react-for-deckgl fix/marker-drag-click-leak (d33041b): deck.gl skips the tap the core already delivered. Both are local branches; repoint these at the merge commits before this goes up.
The sample ignored circle clicks for 300 ms after the edge marker's onDragEnd, because releasing the dragged marker over the circle clicked the circle on the GL providers. js-sdk-core now keeps that click off the map, so the workaround is no longer needed.
The marker click fix is merged in all three: - js-sdk-core#31 (3d2d349): swallow the click that ends a marker gesture, pass a clickable: false tap down the map's cascade, mark the pointerup; - react-for-deckgl#10 (c7b6c91): skip the tap the core already delivered; - react-for-azuremaps#14 (1f24e70): drag markers through the core's DefaultMarkerEventController (drag threshold, no click after release).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
なぜ
マーカーを掴んだジェスチャの後のブラウザの click が地図に届き、頂点ドラッグを離した位置のポリゴンがクリックされたり、clickable なマーカーの onClick が 2 回出たりしていた（GL 系・deck.gl）。Azure はドラッグのしきい値が無く、動かさずに離しても dragEnd ＋ 下のサークルの onClick が出ていた。修正は各サブモジュールでマージ済み:
何を変えたか
examples/basicの CirclePage: マーカーのドラッグ直後のサークルのクリックを握りつぶしていたSUPPRESS_CIRCLE_CLICK_AFTER_MARKER_DRAG_MSを外した。SDK 側で直ったので不要（外したことで Azure の不具合が見えるようになり、build(deps-dev): bump undici from 8.10.0 to 8.11.2 #14 で直した）。検証
scripts/api-surface.mjs check js-sdk-core react-for-deckgl react-for-azuremaps: ok。確認できていないもの