Repository navigation
refactor(config): centralize typed settings and lazy provider composition - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move provider configuration into typed Settings and a single composition root. Credentials are redacted from settings representations, model loading is lazy, and provider selection preserves the existing cloud priority and Ollama fallback.
Dependency and review order
Slice 2/8. Depends on #5 (#5). Current base:
refactor/core-contracts, so this diff contains this slice only; final integration target isdevelop. Review in order. After the predecessor merges, rebase this branch onto develop if it was squash merged, then retarget this PR to develop before merging it. Keep the predecessor branch until retargeting is complete.Validation
Local offline suite: 110 tests passed. Config validation, credential redaction, provider priority and lazy construction checks passed. Remote quality checks are pending publication/runner completion.
Compatibility and rollback
Configuration/provider wiring. Preserve BGE-M3/1024D and existing model defaults; no data migration. Revert this slice if needed and retain SQL/vector volumes. Maintainer review is pending; auto-merge is not enabled.