Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace import-time SQL engine creation with an explicitly owned Database and scoped repositories. Document reads/mutations require authenticated ownership and return detached data; authentication and progress use injected session factories.
Dependency and review order
Slice 3/8. Depends on #6 (#6). Current base:
refactor/config-bootstrap, so this diff contains this slice only; final integration target isdevelop. Review in order. After the predecessor merges, rebase this branch onto develop if it was squash merged, then retarget this PR to develop before merging it. Keep the predecessor branch until retargeting is complete.Validation
Local offline suite: 112 tests passed, including detached results, ownership and no import-time database construction. Final stack also passed fresh PostgreSQL upgrade/check and three integration tests. Remote quality checks are pending publication/runner completion.
Compatibility and rollback
Persistence and authorization. Preserve tables, Alembic p0_0001 and historical string QuizAttempt.user_id; no migration/reindex. Revert this slice if needed and retain SQL/vector volumes. Maintainer review is pending; auto-merge is not enabled.