Repository navigation
Conversation
… application services
refactor(repository): consolidate configuration and remove legacy runtime namespaces
…gacy runtime namespaces"
Revert "refactor(repository): consolidate configuration and remove legacy runtime namespaces"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the existing ReAct parser/tools into legacy_react and introduce an account-bound LearningSession/AnswerQuestionUseCase. Streamlit under apps/streamlit_legacy calls application services for ingestion, chat, quiz and progress; user IDs are no longer prefixed into model questions. Update Docker to the package-safe entrypoint.
Dependency and review order
Slice 7/8. Depends on #10 (#10). Current base:
refactor/learning-services, so this diff contains this slice only; final integration target isdevelop. Review in order. After the predecessor merges, rebase this branch onto develop if it was squash merged, then retarget this PR to develop before merging it. Keep the predecessor branch until retargeting is complete.Validation
Local offline suite: 119 tests passed. Docker build/start, persisted SQL/Chroma read smoke and Streamlit AppTest registration/logout/B-login passed. Components are checked against direct storage/provider/orchestrator imports. Remote quality checks are pending publication/runner completion.
Compatibility and rollback
Runtime entrypoint and UI orchestration. Preserve the five-step parser baseline and provider behavior; temporary legacy aliases remain for the following cleanup slice. Existing volumes were backed up before image changes. Revert this slice if needed and retain SQL/vector volumes. Maintainer review is pending; auto-merge is not enabled.