Repository navigation
refactor(repository): consolidate configuration and remove legacy runtime namespaces - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove root src/ui after callers migrate, unify offline tests under backend/tests, move opt-in evaluation into evaluation, and retire unused patch scripts. Declare dependencies once in backend/pyproject.toml, move generated locks to requirements and env templates to config, and update Docker/CI/docs.
Includes a focused citation fix found by real-browser verification: Streamlit previously discarded source chips after rerun because history saved only answer text. Store Evidence DTOs with assistant history and render them again; add an AppTest reproducing that path.
Dependency and review order
Slice 8/8. Depends on #11 (#11). Current base:
refactor/agent-ui-boundary, so this diff contains this slice only; final integration target isdevelop. Review in order. After the predecessor merges, rebase this branch onto develop if it was squash merged, then retarget this PR to develop before merging it. Keep the predecessor branch until retargeting is complete.Validation
122 offline tests passed on Windows/Python 3.12 and Linux/Python 3.11, plus three fresh PostgreSQL integration tests. Clean clone/editable install, wheel/sdist and imports outside the repo passed. Docker health, legacy data read, backup/isolated restore, persistence after down/up, real BGE-M3/Ollama smoke and Chromium A/B upload/chat/citations/quiz/grade/logout/resume passed. Human review and remote CI remain pending. Remote quality checks are pending publication/runner completion.
Final-tree local evidence: repository consolidation acceptance. This PR contains three focused commits (requirements/env cleanup, namespace/QA consolidation, citation rerun fix).
Compatibility and rollback
Namespace/build/config cleanup and the intentional citation visibility fix. All locked runtime versions, SQL/Alembic schema and Chroma model/dimension/IDs remain unchanged. Existing local secrets are unchanged and ignored. No FastAPI/LangGraph/Next.js feature is introduced. Revert this slice if needed and retain SQL/vector volumes. Maintainer review is pending; auto-merge is not enabled.