Skip to content

test: avoid public IP addresses in HTML-to-Markdown URL safety tests #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adulau merged 1 commit into from
Sep 25, 2026
Merged

test: avoid public IP addresses in HTML-to-Markdown URL safety tests #907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions tests/test_html_to_markdown.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@


class TestHtmlToMarkdownUrlSafety(unittest.TestCase):
# 192.0.2.0/24 is reserved for documentation and examples (TEST-NET-1).

def test_blocks_ipv4_mapped_ipv6_literals_for_blocked_ipv4_ranges(self):
blocked_urls = (
Expand All @@ -22,16 +23,16 @@ def test_blocks_ipv4_mapped_ipv6_literals_for_blocked_ipv4_ranges(self):
with self.subTest(url=url):
self.assertFalse(is_safe_url(url))

def test_allows_public_ipv4_mapped_ipv6_literal(self):
self.assertTrue(is_safe_url("http://[::ffff:93.184.216.34]/"))
def test_allows_unblocked_ipv4_mapped_ipv6_literal(self):
self.assertTrue(is_safe_url("http://[::ffff:192.0.2.1]/"))

def test_allows_public_ipv4_literal(self):
self.assertTrue(is_safe_url("http://93.184.216.34/"))
def test_allows_unblocked_ipv4_literal(self):
self.assertTrue(is_safe_url("http://192.0.2.1/"))

def test_allows_hostnames_resolving_to_public_ipv4_addresses(self):
def test_allows_hostnames_resolving_to_unblocked_ipv4_addresses(self):
with patch(
"misp_modules.modules.expansion.html_to_markdown.socket.getaddrinfo",
return_value=[(None, None, None, None, ("93.184.216.34", 0))],
return_value=[(None, None, None, None, ("192.0.2.1", 0))],
):
self.assertTrue(is_safe_url("http://example.test/"))

Expand Down Expand Up @@ -63,10 +64,10 @@ def test_blocks_redirect_to_loopback(self, session_factory):
session.get.return_value = response

with self.assertRaisesRegex(ValueError, "Blocked redirect URL"):
fetchHTML("http://93.184.216.34/")
fetchHTML("http://192.0.2.1/")

session.get.assert_called_once_with(
"http://93.184.216.34/", timeout=10, allow_redirects=False
"http://192.0.2.1/", timeout=10, allow_redirects=False
)
response.close.assert_called_once_with()

Expand All @@ -75,20 +76,20 @@ def test_reuses_session_when_following_safe_redirect(self, session_factory):
session = session_factory.return_value.__enter__.return_value
redirect_response = Mock(
is_redirect=True,
headers={"location": "http://93.184.216.35/destination"},
headers={"location": "http://192.0.2.2/destination"},
)
final_response = Mock(is_redirect=False, text="redirected content")
session.get.side_effect = [redirect_response, final_response]

self.assertEqual(fetchHTML("http://93.184.216.34/"), "redirected content")
self.assertEqual(fetchHTML("http://192.0.2.1/"), "redirected content")

session_factory.assert_called_once_with()
self.assertEqual(
session.get.call_args_list,
[
call("http://93.184.216.34/", timeout=10, allow_redirects=False),
call("http://192.0.2.1/", timeout=10, allow_redirects=False),
call(
"http://93.184.216.35/destination",
"http://192.0.2.2/destination",
timeout=10,
allow_redirects=False,
),
Expand Down