Skip to content

test: avoid public IP addresses in HTML-to-Markdown URL safety tests - #907

Merged
adulau merged 1 commit into
mainfrom
codex/avoid-public-ip-in-tests
Sep 25, 2026
Merged

adulau merged 1 commit into
mainfrom
codex/avoid-public-ip-in-tests

Conversation

@adulau

@adulau adulau commented Sep 25, 2026

Copy link
Copy Markdown
Member

Motivation

  • Tests referenced real public addresses (93.184.216.34/35) which can make CI or local runs touch public IPs; using reserved test-net addresses avoids that risk.

Description

  • Replaced occurrences of 93.184.216.34/93.184.216.35 with RFC 5737 TEST-NET-1 addresses (192.0.2.1 and 192.0.2.2) in tests/test_html_to_markdown.py.
  • Renamed positive test cases to describe "unblocked" addresses instead of "public" addresses to clarify intent.
  • Added a comment noting that 192.0.2.0/24 is reserved for documentation and examples.
  • Kept redirect tests fully mocked using requests.Session so no real network requests occur during the tests.

Testing

  • Ran python -m pytest tests/test_html_to_markdown.py and all tests passed (10 passed, 5 subtests passed).
  • Ran git diff --check with no issues reported.

Codex Task

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T14:46:27.430119Z aed1171 PR opened
🔒 Security Review ✅ Completed 2026-09-25T14:46:53.531445Z aed1171 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@adulau
adulau merged commit f25ef2f into main Sep 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant