Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
1ed587a
chore: release 1.4.0, begin 1.4.1.dev0 development (#5371)
mnriem Nov 10, 2026
5130f35
Update Intake Authoring Governance preset to v0.3.12 (#5372)
github-actions[bot] Nov 10, 2026
ff22e88
Update DocGuard — CDD Enforcement to v0.47.0 (#5374)
github-actions[bot] Nov 10, 2026
f29319d
[extension] Add A·I·DID·IT — Agile Expansion Pack extension to commun…
github-actions[bot] Nov 10, 2026
a91b63a
Use handle-based deletion in FileHelper (#5352)
mnriem Nov 11, 2026
bdd70d3
Update ado-lifecycle to 0.3.2 (#5345)
praveenlavu Nov 11, 2026
9972d21
fix(integrations): honor shared refresh for installed targets (#5377)
WOLIKIMCHENG Nov 11, 2026
40dd00f
Update Intake Review Governance preset to v0.2.8 (#5388)
github-actions[bot] Nov 11, 2026
979b0a3
fix(workflows): expose bundled review verdict inputs (#5392)
mnriem Nov 11, 2026
684b170
Update Intake Sequencing Governance preset to v0.2.13 (#5406)
github-actions[bot] Nov 12, 2026
f614371
Update T-Shirt Sizing Gate extension to v0.2.0 (#5407)
github-actions[bot] Nov 12, 2026
d059748
[extension] Add OKR Bets extension to community catalog (#5412)
github-actions[bot] Nov 12, 2026
0cca064
docs(extensions): list the converge hook events (#5328)
alfredoperez Nov 12, 2026
07ef2c8
fix(powershell): treat project and preset template paths literally (#…
kartsan03 Nov 12, 2026
2ee2b1e
fix(powershell): treat bracketed project paths literally in create-ne…
adityajai119 Nov 12, 2026
435b306
fix(powershell): treat bracketed project paths literally in the git e…
adityajai119 Nov 16, 2026
3050be0
Add Multi-Repo Workspace Orchestration extension to community catalog…
github-actions[bot] Nov 16, 2026
015e0fa
[preset] Add OKR Bet Spec Section preset to community catalog (#5439)
github-actions[bot] Nov 16, 2026
4a637b2
Add Spec Kit lifecycle for Jira extension to community catalog (#5438)
github-actions[bot] Nov 16, 2026
28a3f22
Add Elephant-Goldfish Model extension to community catalog (#5444)
github-actions[bot] Nov 16, 2026
4b570b6
chore: bump version to 1.4.1
github-actions[bot] Nov 16, 2026
b08b4e3
Merge upstream tag v1.4.1 and set fork version 1.4.1+mas.1
cursoragent Nov 16, 2026
e3490e6
Restore constitution helper import and drop removed --no-git flag
cursoragent Nov 16, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,35 @@

<!-- insert new changelog below this comment -->

## [1.4.1+mas.1] - 2026-11-16

MAS fork release based on upstream Spec Kit 1.4.1. Package version uses the local `+mas.N` convention; Git tags for this fork remain `vX.Y.Z-mas.N`.

## [1.4.1] - 2026-11-16

### Changed

- Add Elephant-Goldfish Model extension to community catalog (#5444)
- Add Spec Kit lifecycle for Jira extension to community catalog (#5438)
- [preset] Add OKR Bet Spec Section preset to community catalog (#5439)
- Add Multi-Repo Workspace Orchestration extension to community catalog (#5436)
- fix(powershell): treat bracketed project paths literally in the git extension (#5404)
- fix(powershell): treat bracketed project paths literally in create-new-feature (#5399)
- fix(powershell): treat project and preset template paths literally (#5396)
- docs(extensions): list the converge hook events (#5328)
- [extension] Add OKR Bets extension to community catalog (#5412)
- Update T-Shirt Sizing Gate extension to v0.2.0 (#5407)
- Update Intake Sequencing Governance preset to v0.2.13 (#5406)
- fix(workflows): expose bundled review verdict inputs (#5392)
- Update Intake Review Governance preset to v0.2.8 (#5388)
- fix(integrations): honor shared refresh for installed targets (#5377)
- Update ado-lifecycle to 0.3.2 (#5345)
- Use handle-based deletion in FileHelper (#5352)
- [extension] Add A·I·DID·IT — Agile Expansion Pack extension to community catalog (#5375)
- Update DocGuard — CDD Enforcement to v0.47.0 (#5374)
- Update Intake Authoring Governance preset to v0.3.12 (#5372)
- chore: release 1.4.0, begin 1.4.1.dev0 development (#5371)

## [1.4.0] - 2026-11-10

### Changed
Expand Down
13 changes: 13 additions & 0 deletions bundles/bugfix/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,19 @@ specify workflow run bugfix \

Required inputs must be supplied with `--input`: `report` and `slug`. The slug is used as the working directory under `.specify/bugs/<slug>/` for all artifacts.

Without an interactive terminal, the run pauses at `review-assessment`. Review
the assessment, then approve it using the optional verdict input:

```bash
specify workflow resume <run_id> --input bug_review_assessment_verdict=approve
```

`bug_review_assessment_verdict` defaults to `""`. Omitting it or supplying an
empty value preserves the existing interactive prompt or non-interactive pause.
This input is available in `bugfix` workflow version 1.0.1 and requires Specify
CLI 0.15.1 or later. Update the workflow and start a new run to use the input;
existing runs retain the definition saved when they started.

## Remove

```bash
Expand Down
6 changes: 3 additions & 3 deletions bundles/bugfix/bundle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ schema_version: "1.0"
bundle:
id: "bugfix"
name: "Guided Bug Fix"
version: "1.0.2"
version: "1.0.3"
role: "developer"
description: "Orchestrated bug triage: assess a bug report, review the assessment behind a human gate, apply the fix, and verify it with tests."
author: "GitHub"
license: "MIT"

requires:
speckit_version: ">=0.9.0"
speckit_version: ">=0.15.1"
tools: []
mcp: []

Expand All @@ -20,6 +20,6 @@ provides:
version: "1.0.2"
workflows:
- id: "bugfix"
version: "1.0.0"
version: "1.0.1"

tags: ["bug", "triage", "workflow", "qa"]
6 changes: 3 additions & 3 deletions bundles/catalog.json
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
{
"schema_version": "1.0",
"updated_at": "2026-09-10T00:00:00Z",
"updated_at": "2026-11-11T00:00:00Z",
"catalog_url": "https://raw.githubusercontent.com/github/spec-kit/main/bundles/catalog.json",
"bundles": {
"bugfix": {
"id": "bugfix",
"name": "Guided Bug Fix",
"version": "1.0.2",
"version": "1.0.3",
"role": "developer",
"description": "Orchestrated bug triage: assess a bug report, review behind a human gate, apply the fix, and verify with tests.",
"author": "GitHub",
"license": "MIT",
"download_url": "https://raw.githubusercontent.com/github/spec-kit/main/bundles/bugfix/bundle.yml",
"repository": "https://github.com/github/spec-kit",
"requires": {
"speckit_version": ">=0.9.0"
"speckit_version": ">=0.15.1"
},
"provides": {
"extensions": 1,
Expand Down
5 changes: 4 additions & 1 deletion design/catalogs.md
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,10 @@ Current behavior differs by primitive:
sources fetch repository catalogs when online and fall back to packaged
snapshots only for catalog-unavailable failures; malformed or unsafe content
is not masked by the snapshot. Bundle stacks memoize parsed payloads for the
lifetime of one stack instance.
lifetime of one stack instance. When translating an HTTP status error, the
fetcher closes its response body before propagating the catalog error, while
retaining the original exception as its cause and preserving status-based
fallback classification.

A future shared fetch boundary may share URL validation, redirect validation,
bounded reads, cache records, and error types. It must preserve each
Expand Down
158 changes: 144 additions & 14 deletions design/file-helper.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@ the policy. `specify_cli._project.resolve_specify_project_files()` performs the
normal existing-project resolution and returns the same handoff for new CLI
adapters. Commands using another established root call `project_files` on
their actually selected root. Retain a helper only for the current operation;
a later invocation resolves a new helper, so manual edits take effect.
a later invocation resolves a new helper, so manual edits take effect. Use the
returned owner as a context manager, or call `close()` in the owner's cleanup
path, to release retained root handles at that operation boundary.

The `specify_cli.integration_state` helpers are an explicit managed-metadata
exception to this handoff. Their reads and writes of `.specify/integration.json`
Expand Down Expand Up @@ -101,12 +103,12 @@ existing lifecycle rollback, including prior policy and unrelated options.
```python
from specify_cli.file_helper import FileHelper

files = FileHelper(project_root) # deny symlinks by default
files.mkdir("generated", exist_ok=True)
files.create_text("generated/config.txt", "initial\n")
files.write_text("generated/config.txt", "updated\n")
content = files.read_text("generated/config.txt")
files.delete("generated", recursive=True)
with FileHelper(project_root) as files: # deny symlinks by default
files.mkdir("generated", exist_ok=True)
files.create_text("generated/config.txt", "initial\n")
files.write_text("generated/config.txt", "updated\n")
content = files.read_text("generated/config.txt")
files.delete("generated", recursive=True)
```

## Boundary and policy
Expand Down Expand Up @@ -144,6 +146,66 @@ any followed target hierarchy. An unrelated project symlink does not prevent
an operation. A helper cannot cross to another root; callers establish separate
helpers for independent project/source/managed boundaries.

On supported deletion backends, construction retains a handle to the canonical
root until `close()` or context-manager exit. Keeping the original directory open
prevents its identity from being reused for a different directory while the
helper is alive; stored device/inode numbers alone are not the binding. On POSIX,
the handle uses search-only access where available. On Windows, construction
requests only root metadata access (`FILE_READ_ATTRIBUTES`) and permits delete
sharing; it does not request directory-list access on the canonical ancestors.
The retained reference selects a tagged identity scheme from that handle.
The full 128-bit `FileIdInfo` identity is preferred. If that query reports
`ERROR_INVALID_FUNCTION`, `ERROR_NOT_SUPPORTED`, or `ERROR_INVALID_PARAMETER`,
or returns an all-zero ID, the helper queries the opened volume's filesystem
and uses `GetFileInformationByHandle`'s volume serial plus nonzero 64-bit file
index only for FAT, FAT32, exFAT, or NTFS. The volume query is handle-relative
and works through the filesystem driver rather than a pathname-based volume
lookup, including when a network driver exposes the necessary information.
ReFS and unrecognized filesystems do not fall back to potentially ambiguous
64-bit indexes. Access-denied, sharing, and other unrelated errors still
propagate rather than selecting a weaker identity.
Before accepting it, construction compares Python-native metadata obtained from
the acquired handle with the initially observed root metadata. This comparison
does not reopen the root pathname, so replacement followed by restoration cannot
substitute a different retained object. The metadata query uses a temporary
non-inheritable duplicate and leaves the original reference open.
If that reference or identity query is unavailable, the native capability error
is deferred to `delete()` rather than preventing ordinary read/write operations.
The cached error remains traceback-free; each failed deletion raises an
independent shallow copy retaining the native error type and filesystem details.

Windows deletion separately pins the canonical ancestry through the drive/share
root without delete sharing, then queries both that root handle and the retained
reference using the already selected scheme. It compares their live identities,
not a cached legacy index: FAT IDs can change after renaming. It neither
renegotiates identity schemes mid-operation nor compares identities from
different schemes. Those operation-time handles require both
`FILE_LIST_DIRECTORY` and `FILE_READ_ATTRIBUTES` on every canonical ancestor,
including those above the helper root, and reject reparse points. An ACL allowing
traversal but not listing can therefore prevent deletion while still allowing
bootstrap reads. Windows deletion also retains non-reparse handles to accessed
parent directories throughout link resolution, before classifying child entries
or reading link targets. Each child is opened relative to its native parent
handle, not by reconstructing an absolute pathname. Metadata and symbolic-link
targets are read from opened leaf handles; directory names are enumerated from
the directory handle. Relative native opens request both
`FILE_SYNCHRONOUS_IO_NONALERT` and `SYNCHRONIZE`, including directories, so
enumeration cannot consume a buffer before a pending directory query completes.
These accessed directories also require
directory-list/read-attribute access. The resolution handles are released after
selection; native mutation parents and root ancestry remain retained during
preflight and removal. Directory sharing locks alone do not prevent in-place
reparse changes: handle-relative operations retain the opened directory object
instead of following its changed pathname. These locks are released at the end of
deletion; the metadata-only reference remains until the helper closes. Automatic
finalization is a compatibility fallback, not a substitute for deterministic
cleanup. Bootstrap configuration and managed integration-state consumers close
their own helpers explicitly. Installed-workflow listing also closes its
`project_files()` owner on every validation, registry-read, and successful exit;
other consumers receiving `project_files()` own its lifetime.
Pinning the root does not make other pathname-based operations
descriptor-relative or change their documented concurrency limitations.

| Operation | Default deny | Explicit allow |
|---|---|---|
| Read file | Reject accessed parent or leaf links | Follow only existing contained regular-file targets |
Expand All @@ -158,6 +220,9 @@ helpers for independent project/source/managed boundaries.

## API and failures

- `close()` releases the helper's retained root handles and is idempotent.
`with FileHelper(...) as files:` closes on both success and failure. Operations
on an explicitly closed helper raise `FileHelperError`.
- `mkdir(path, parents=False, exist_ok=False)` creates directories.
- `read_bytes(path)` / `read_text(path, encoding="utf-8")` read regular files.
- `create_bytes(path, content, mode=0o644)` / `create_text(...)` exclusively
Expand Down Expand Up @@ -224,7 +289,58 @@ helpers for independent project/source/managed boundaries.
the attributes of an existing file.
- `delete(path, recursive=False)` unlinks files/links or removes directories.
Nonrecursive directory deletion requires an empty directory. The established
root cannot be deleted.
root cannot be deleted. Recursive enumeration and each removal use anchored
directories. Each deletion borrows the root handle retained at construction,
checks the currently named root for replacement, and uses that original anchor through
preflight and all removals. POSIX uses this retained root for component
classification, link-target reads and resolution, recursive preflight, and
per-entry revalidation, as well as descriptor-relative enumeration and
`unlink`/`rmdir`. Canonical pathnames identify root-relative entries but are not
reopened for metadata or link resolution. Windows verifies the full canonical
ancestry during root acquisition and then carries native directory handles
through child opens, metadata queries, link-target reads, and enumeration.
Removal opens the leaf itself with `DELETE` access and marks that same handle
with `FileDispositionInfo`; it does not call pathname `unlink` or `rmdir`.
This does not change the trusted treatment of aliases resolved
at root establishment. Allowed contained parent links are resolved within the
retained boundary, and leaf links are still unlinked rather than followed.
Platforms lacking the required directory-descriptor operations fail with
`ENOTSUP`, not pathname-only deletion.
POSIX traversal and removal use search/path-only descriptors (`O_SEARCH` or
`O_PATH`) where available, including Darwin's native `O_SEARCH` value on Python
builds that do not expose it, so known entries in write-and-execute-only parents
can still be removed. Read-capable descriptors are requested only for directories
being enumerated; systems without search/path-only flags retain read-capable
traversal. Recursive enumeration still requires directory read permission, and
removal still requires the operating system's normal directory permissions.
Preflight opens the enumerated child directly as readable, relative to its
anchored parent, without a search-only open or `"."` reopening first. An empty
readable directory therefore does not need its own search permission to be
removed; accessing children in a nonempty directory still requires search
permission. The parent still needs the permissions required to remove its
directory entry.
On systems using the read-capable fallback, root establishment also requires
read permission on the root.
POSIX component resolution and final parent anchoring retain only the current
traversal descriptor, opening its child before releasing the preceding one.
Their live descriptor count is bounded independently of operation-path depth,
in addition to the helper's retained root. Link-target jumps and `..` are
re-anchored through that root rather than following an opened directory's
physical parent after a rename. Windows retains native directory handles for
its child-relative traversal, including during recursive preflight and removal.
POSIX recursive preflight and mutation use explicit worklists and separate
eight-directory handle caches. The selected parent and established root remain
anchored outside those caches. An uncached parent is reacquired component by
component from the nearest retained prefix with no-follow flags, releasing
least-recently-used handles as the cache fills. Removed directories are evicted,
and preflight handles are not reused for mutation. Live descriptors are bounded
independently of recursive depth, including transient opens and enumeration;
worklist and complete-plan memory still scale with the selected tree.
Reacquiring evicted prefixes trades additional opens for that fixed handle
budget. Total opens can grow with the sum of visited path lengths, rather than
being unconditionally linear in the directory count. Windows retains its
native-handle traversal instead of evicting handles needed for child-relative
operations. The complete plan is still preflighted before any removal.
- `symlink(target, path)` creates a link exclusively. Relative targets are
interpreted relative to the link parent, not the helper root.

Expand Down Expand Up @@ -283,11 +399,23 @@ substituted symlink. This does not freeze file contents against in-place edits.

Preflight detects static policy failures before recursive deletion or parent
creation. Atomic writes recheck the original path before replacement, and
deletion rechecks each accessed entry. No operation is a general race-free
sandbox. For operations that still use validated paths, another process can
exchange parents or entries between checks and syscalls. An I/O failure during
any mutation can leave partial results. Protect against concurrent untrusted
mutation separately.
deletion rechecks each accessed entry. Deletion also anchors directory
enumeration and removal so exchanging an accessed parent for a link cannot
redirect those operations. Reopening the absolute root pathname for each entry is
avoided; the established root handle is never rebound to a replacement, even if
device/inode values are reused. POSIX removal stays attached to
the opened directory even if that directory is renamed; validation continues to
inspect that same directory tree. Windows prevents ancestor renames while handles
are held. Concurrent changes may still cause deletion to fail or leave
partial results, and preflight is not a transaction or an immutable tree snapshot.
POSIX leaf removal acts on the current entry in the anchored parent; Windows
removal acts on its opened leaf handle. No operation is a general race-free
sandbox. For operations that still
use validated paths (reads, directory creation, atomic writes, and symlink
creation), portable path checks are **not**
a race-free sandbox: another process can exchange parents or entries between
checks and syscalls, and an I/O failure during mutation can leave partial
results. Protect against concurrent untrusted mutation separately.
Exclusive file creation anchors its resolved parent hierarchy as described
above. On POSIX, renaming an opened directory does not redirect creation to
its replacement: creation stays with the opened directory, even if it is
Expand Down Expand Up @@ -317,7 +445,9 @@ rather than falling back to path-based overwrite.
Windows path classification and directory-mode reparse rejection have portable
regression tests. Native Windows path and junction tests also exist and are
skipped on other hosts; running the portable cases on macOS does not validate
Windows filesystem syscalls or junction behavior. Exclusive-creation tests
Windows filesystem syscalls or junction behavior. Deletion replacement tests
exercise swaps at enumeration and removal boundaries on the native host; Windows
handle-sharing behavior requires a native Windows run. Exclusive-creation tests
cover parent replacement before anchoring and at the final open, along with
native Windows parent-handle pinning and portable handle-lifetime checks;
portable checks do not substitute for native Windows execution.
Loading
Loading