Skip to content

Sync upstream v1.4.1 (v1.4.1-mas.1) - #7

Merged
mbarrerarod merged 23 commits into
mainfrom
sync-upstream-v1.4.1
Nov 16, 2026
Merged

mbarrerarod merged 23 commits into
mainfrom
sync-upstream-v1.4.1

Conversation

@mbarrerarod

Copy link
Copy Markdown

Description

Sincroniza el fork MAS con el release publicado de GitHub Spec Kit v1.4.1 (no prerelease, publicado el 2026-11-16). La versión del paquete queda en 1.4.1+mas.1. No se crea tag y no se fusiona este PR.

El rango incluido respecto a main (que ya contenía v1.4.0) es v1.4.0..v1.4.1. Entradas del changelog upstream:

mas-stack-nestjs-react no está en origin/main; no se importó desde otras ramas.

Conflictos y resolución

Solo dos conflictos en el merge (no rebase) de v1.4.1:

Archivo Resolución
pyproject.toml Versión del fork 1.4.1+mas.1 (convención +mas.N; los tags Git siguen vX.Y.Z-mas.N).
CHANGELOG.md Se conserva la sección upstream 1.4.1 y se añade la entrada de fork 1.4.1+mas.1.

Los workflows de release (.github/workflows/release.yml, release-trigger.yml, publish-pypi.yml) no los tocó este delta de upstream y siguen aceptando vX.Y.Z-mas.N e instalando desde MAS-Consultores/spec-kit. Stacks, constituciones, guidelines y presets MAS (mas-core, cakephp2-mysql, moodle3, moodle5-plugin, moodle5-portal, laravel-inertia-react) se mantienen. Los workflow.yml de speckit y bugfix coinciden con v1.4.1: en main eran la variante anterior (sin verdict_input), no una personalización MAS distinta.

Ajuste posterior al merge: ensure_constitution_from_template se reexporta desde command_init (upstream lo espera ahí; la implementación MAS sigue en el paquete). Los tests de skills externos dejan de pasar --no-git, opción que el CLI ya rechaza.

Testing

  • CLI instalada desde esta rama: specify 1.4.1+mas.1
  • uvx ruff@0.15.0 check src tests — no verde. 15 F401 ya presentes en el fork (reexportaciones MAS en src/specify_cli/__init__.py y imports sin uso). Este sync no los introduce.
  • .venv/bin/python -m pytest tests -q --tb=line -n auto — 618 failed, 15646 passed, 577 skipped, 48 warnings, 48 errors en 375 s. La causa dominante (571 mensajes) es que el fork exige --stack y los tests upstream llaman a specify init sin stack. No se relajó esa regla.

specify init por stack

CLI: uv tool install editable de esta rama. Comando no interactivo: specify init <dir> --integration codex --stack <id> --ignore-agent-tools --script sh --skip-external-skills --non-interactive.

Stack Resultado Stack / presets Constitution, guidelines, memoria Plantillas /speckit-*
cakephp2-mysql pass mas-core + mas-stack-cakephp2-mysql constitution, stack, security-guidelines, stack-context, language-policy 9 skills en .agents/skills/speckit-*
moodle3 pass mas-core + mas-stack-moodle3 igual 9 skills
moodle5-plugin pass mas-core + mas-stack-moodle5-plugin igual 9 skills
moodle5-portal pass mas-core + mas-stack-moodle5-portal igual 9 skills
laravel-inertia-react pass mas-core + mas-stack-laravel-inertia-react igual 9 skills
not-a-stack pass (error claro, exit 1) — no crea el proyecto útil mensaje Invalid --stack value 'not-a-stack' y lista de IDs válidos

AI Disclosure

  • I did not use AI assistance for this contribution
  • I did use AI assistance (fill in the disclosure below)

AI disclosure: Cursor Grok 4.7 (modelo grok-4.7, autónomo) hizo el merge, la resolución de conflictos, los ajustes de importación/--no-git, la ejecución de pytest, ruff y el init de cada stack, y redactó este PR. No hubo revisión humana línea a línea.

Open in Web Open in Cursor 

mnriem and others added 23 commits November 10, 2026 15:26
* chore: bump version to 1.4.0

* chore: begin 1.4.1.dev0 development

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Update intake-authoring-governance preset submitted by @hindermath:
- presets/catalog.community.json (version, download_url, sha256, tags, timestamps)
- docs/community/presets.md community presets table (validated; no row content change needed)

Closes github#5370

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update docguard extension submitted by @raccioly:
- extensions/catalog.community.json (version, download_url, sha256, updated_at)

Closes github#5373

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ity catalog (github#5375)

* Add A·I·DID·IT — Agile Expansion Pack extension to community catalog

Add aididit extension submitted by @RandomJedaii to:
- extensions/catalog.community.json (alphabetical order)
- docs/community/extensions.md community extensions table

Closes github#5368

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Sort aididit catalog entry alphabetically

Co-authored-by: mnriem <15701806+mnriem@users.noreply.github.com>

* Place aididit after aide in community catalog

Co-authored-by: mnriem <15701806+mnriem@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mnriem <15701806+mnriem@users.noreply.github.com>
* fix: use handle-based FileHelper deletion

Anchor recursive enumeration and entry removal to directory handles while preserving supported symlink behavior. Share the Windows handle primitive and document deletion semantics.

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* fix: retain deletion roots and preserve directory permissions

Reuse one identity-checked root anchor throughout deletion. Use search-only POSIX descriptors for traversal and request read access only for recursive enumeration. Keep Windows canonical ancestors held for the operation.

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* fix: resolve deletion paths through the retained root

Use descriptor-relative metadata and link reads in the existing path walker for POSIX deletion. Keep initial validation, recursive classification, and per-entry checks on the same retained directory tree as removal, while preserving supported symlink behavior.

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* fix: retain root handles and bound deletion traversal

Keep helper roots pinned until explicit close or context exit, and close bootstrap consumers deterministically. Carry parent descriptors through component resolution and both recursive deletion passes. Cover root cleanup, bounded directory opens, and POSIX backends without search-only flags.

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* fix: preserve helper access and close operation owners

Share Darwin search-only flags, preserve deep deletion planning, and keep Windows root identity references distinct from operation-time ancestry pins. Close workflow owners on every exit and cover constructor diagnostics, retained-error cleanup, recursive handles, and overwrite failures.

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* fix: validate acquired root metadata and isolate native errors

Compare metadata from the borrowed Windows root handle with the initial root observation. Use a temporary non-inheritable duplicate for native fstat without closing the original reference. Raise fresh copies of saved capability errors and cover acquisition restoration, error independence, and duplicate cleanup.

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* fix: preserve the Windows native error code when copying

Restore OSError.winerror explicitly after shallow copying, since Windows omits that built-in slot from its copy protocol. Add a portable regression for lossy copies while keeping independent traceback ownership.

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* fix: anchor Windows parent lookup during deletion

Pin accessed Windows directories before inspecting children or reading link targets, reusing the anchored component walker. Exercise swaps only during pinned root acquisition, distinguish replacement handles, and cover parent replacement for file and recursive removal while preserving native error contracts.

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* fix: preserve recursive directory permission behavior

Open enumerated children directly with readable no-follow directory handles instead of requiring a search-only open and dot reopening. Cover readable empty directories without search permission, nested preflight behavior, and preserved unreadable/nonempty failures.

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* fix: bound descriptors during POSIX deletion traversal

Keep only the current POSIX traversal descriptor while retaining the root anchor, and reuse bounded traversal for final parent acquisition. Re-anchor link-target jumps and parent components through the retained root, preserve Windows ancestry pinning, and cover deep paths under a 64-descriptor process limit.

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* fix: bound recursive POSIX deletion handles

Use explicit preflight and postorder worklists with bounded directory caches. Retain the selected parent and root, reopen evicted prefixes without following links, and preserve complete preflight and Windows ancestry locks. Cover both recursive phases under a 64-descriptor process limit, cache eviction, cleanup, and measured open-work budgets.

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* fix: support legacy Windows file identity queries

Prefer tagged extended IDs and use reliable legacy volume/index identities when the filesystem does not support FileIdInfo. Keep the retained root reference, query both live handles using the selected scheme, and preserve native capability and permission failures. Cover fallback selection, zero/ambiguous IDs, rename/reused-index cases, and native Windows legacy APIs.

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* fix: close catalog HTTP errors before translating

Release HTTP error responses deterministically before raising catalog errors so delayed cleanup cannot leak resources or warnings into later tests. Preserve transient-status fallback, definitive client errors, original exception causes, and already-closed response behavior.

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* fix: use native handles for Windows deletion operations

Carry directory handles through entry classification, link reads, enumeration and removal. Mark the classified leaf handle for deletion instead of reopening its pathname, preserving supported links and explicit native errors. Cover in-place junction changes and fix operation cleanup tests so constructor calls cannot satisfy their fstat failures.

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* test: exercise native Windows deletion boundaries

Hook parent replacement at native entry disposition and enumeration instead of pathname functions that Windows deletion no longer uses. Simulate reparse metadata through native handle queries and retain actual acquired-parent and final-validation coverage.

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* fix: synchronize relative Windows directory I/O

Request FILE_SYNCHRONOUS_IO_NONALERT together with SYNCHRONIZE for relative directory opens, preserving existing type and no-follow flags. Update native ABI assertions and cover the actual Windows directory handle mode and enumeration contract.

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Workflow ID: ado-lifecycle; Version: 0.3.2; Author: praveenlavu

Moves the entry from 0.3.1 to 0.3.2 (tag-pinned URL and sha256) and updates
the row in docs/community/workflows.md. 0.3.2 fixes a second approval gap
that Copilot found on the merged PR 5312: the PR plan did not name the head
commit in terminal approval mode.

Assisted-by: Claude Code (Claude Sonnet 5.5, human-supervised)
…#5377)

Assisted-by: Codex (model: gpt-6.1-sol, autonomous)
Update intake-review-governance preset submitted by @hindermath:\n- presets/catalog.community.json (version, download_url, etc.)\n- docs/community/presets.md community presets table\n\nCloses github#5378\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix(workflows): expose bundled review verdict inputs

Declare optional, empty-default verdict inputs for the SDD and bugfix review gates. Keep workflow and bundle metadata, documentation, and regression coverage consistent.

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* test(bundles): follow shipped workflow versions

Compare installed workflow registry versions against the canonical bundled definitions instead of stale 1.0.0 literals.

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Update intake-sequencing-governance preset submitted by @hindermath:
- presets/catalog.community.json (version, download_url, sha256, documentation, updated_at)

Closes github#5397

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update sizing extension submitted by @mauriziopinotti:
- extensions/catalog.community.json (version, download_url, etc.)
- docs/community/extensions.md community extensions table

Closes github#5401

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add OKR Bets extension to community catalog

Add okr extension submitted by @juanl to:
- extensions/catalog.community.json (alphabetical order)
- docs/community/extensions.md community extensions table

Closes github#5408

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Shorten OKR Bets catalog description

Co-authored-by: KSchlobohm <23503973+KSchlobohm@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: KSchlobohm <23503973+KSchlobohm@users.noreply.github.com>
…ithub#5396)

* fix(powershell): treat project and preset template paths literally

common.ps1 passed project, preset and extension paths to Test-Path and
Get-ChildItem through -Path, which reads [ and ] as wildcards. In a
project whose path contains brackets, resolve-template, setup-plan,
setup-tasks and check-prerequisites exited 1 while the Bash and Python
scripts succeeded. A preset manifest whose declared file name has
brackets was skipped, so the stock template was used instead.

Use -LiteralPath, as github#4956 and github#4970 did for feature paths.

Assisted-by: Codex CLI (model: gpt-6.1-sol, autonomous)
Assisted-by: Claude Code (model: claude-opus-5-5, autonomous)

* test: accept Git Bash paths in the bracketed setup-tasks parity test

Git Bash on Windows can print MSYS paths such as /c/Users/... for
FEATURE_DIR and TASKS_TEMPLATE, which never equal the native paths the
test built. For the Bash run, also accept the form _bash_posix_path()
gives; Python and PowerShell output is still compared with the native
path.

Assisted-by: Claude Code (model: claude-opus-5-5, autonomous)

* test: run the bracketed-path parity cases without bash

requires_bash skipped each whole test, PowerShell and Python runs
included, wherever bash isn't detected. That covers windows-latest,
where the WSL launcher is rejected, so the PowerShell fix had no
Windows coverage. Run Python and PowerShell always, and Bash when
tests/conftest.py's new HAS_BASH says it works.

Assisted-by: Claude Code (model: claude-opus-5-5, autonomous)

* test: pin the Python that parses preset.yml in the bracketed resolver test

The manifest cases make the Bash and PowerShell resolvers parse
preset.yml with Python. On a Windows runner, PowerShell picked an
ambient python3.exe without PyYAML and failed with yaml_missing. Set
SPECKIT_PYTHON_EXECUTABLE to the test interpreter, as
test_resolve_template_python_parity.py already does elsewhere.

Assisted-by: Claude Code (model: claude-opus-5-5, autonomous)
…w-feature (github#5399)

* fix(powershell): treat bracketed project paths literally in create-new-feature

create-new-feature.ps1 passed the project path to Set-Location, Test-Path
and Get-ChildItem without -LiteralPath, so brackets in that path were read
as wildcards: the script stopped at Set-Location, numbered a new feature
001 again, and treated an existing spec.md as missing under
-AllowExistingBranch.

Fixes github#5398

Assisted-by: OpenCode (model: Claude Opus 5.5, autonomous)

* test(powershell): compare the preserved spec.md as bytes

read_text() translates line endings, so the check could not tell a
preserved spec.md from one rewritten with different newlines. Write
the existing spec with CRLF line endings and compare raw bytes.

Assisted-by: OpenCode (model: Claude Opus 5.5, autonomous)
…xtension (github#5404)

The git extension's PowerShell scripts passed project paths to
Resolve-Path, Test-Path, Set-Location, Get-ChildItem, Get-Content,
Remove-Item and Select-String without -LiteralPath, so brackets in the
path were read as wildcards. initialize-repo.ps1,
create-new-feature-branch.ps1 and auto-commit.ps1 stopped in
Find-ProjectRoot; behind that, a new feature was numbered 001 again,
git-config.yml and -MessageFile were not read, and an event set to
enabled: false was committed under auto_commit.default: true.

Bump the git extension to 1.0.5.

Fixes github#5403

Assisted-by: OpenCode (model: Claude Opus 5.5, autonomous)
…github#5436)

Add multi-repo extension submitted by @joaopaschuino to:
- extensions/catalog.community.json (alphabetical order)
- docs/community/extensions.md community extensions table

Closes github#5393

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…#5439)

* Add OKR Bet Spec Section preset to community catalog

Add okr-bet preset submitted by @juanl to:
- presets/catalog.community.json (alphabetical order)
- docs/community/presets.md community presets table

Closes github#5409

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Clarify OKR Bet Spec Section description

Updated the description of the OKR Bet Spec Section to clarify the bet's verification contract and its relation to the okr extension.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Fix HTML entities in description field

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Ken Schlobohm <keschlob@microsoft.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…b#5438)

Add jira-lifecycle extension submitted by @praveenlavu to:
- extensions/catalog.community.json (alphabetical order)
- docs/community/extensions.md community extensions table

Closes github#5433

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add egm extension submitted by @ksachdeva to:
- extensions/catalog.community.json (alphabetical order)
- docs/community/extensions.md community extensions table

Closes github#5394

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Bring in the published Spec Kit 1.4.1 release while keeping MAS stack,
constitution, guideline, preset, and release-workflow customizations.
The package version follows the local +mas.N convention.

Assisted-by: Cursor Grok 4.7 (model: grok-4.7, autonomous)
Co-authored-by: mbarrerarod <mbarrerarod@users.noreply.github.com>
Upstream v1.4.1 expects ensure_constitution_from_template on command_init.
Re-export the shared MAS implementation. Stack skill tests no longer pass
--no-git, which the CLI rejects.

Assisted-by: Cursor Grok 4.7 (model: grok-4.7, autonomous)
Co-authored-by: mbarrerarod <mbarrerarod@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0ca38a6c-3ed2-4b9c-a83a-84c16f43b9e9
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@mbarrerarod
mbarrerarod merged commit 95e87e9 into main Nov 16, 2026
7 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants