Repository navigation
fix(nfse): preservar API posicional do DpsData ao incluir regApTribSN (#424) - #135
Merged
Merged
Conversation
…424) Append the optional Simples field instead of shifting existing constructor arguments; keep named callers and the E0162/E0166/E0175 serializer intact. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correção de compatibilidade do PR #134
A inclusão de
regimeApuracaoSimplesNacionalno centro do construtor promovidoDpsData::__constructpreservava callers com argumentos nomeados, mas deslocava a posição dos argumentos existentes para consumidores posicionais. Isso seria uma quebra silenciosa evitável.Move o novo campo opcional para o fim do construtor, mantendo todos os parâmetros anteriores na mesma posição, sem modificar a propriedade acessada por nome pelo
XmlBuilder. Adiciona teste de regressão da posição pública. Não altera DANFSe, validações fiscais, emissão, segurança, workflows nem API de outros métodos.Verificação necessária: PHPUnit 8.2/8.3/8.4, Psalm, PHP CS, mínimos, REUSE e DCO. Após merge, atualizar o pin do Akaunting para a revisão final com o contrato compatível. Somente fixtures sintéticas.