Skip to content

fix(danfse): preferir descrição municipal e suprimir linha federal após 2026 (#118) #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitormattos merged 1 commit into from
Oct 12, 2026
Merged

fix(danfse): preferir descrição municipal e suprimir linha federal após 2026 (#118) #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion src/Danfse/DanfseTemplate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,13 @@ public function buildData(array $nfse): array

'servico' => [
'codigo_trib_nacional' => $this->formatter->codTribNacional($this->val($cServ, 'cTribNac')),
'desc_trib_nacional' => $this->formatter->limit(trim($this->val($infNfse, 'xTribNac')), 60),
// NT008 2.4.5 prefers an authorized municipal description
// over the national one. The length is suggested, not a new
// tax-code validation or data mutation.
'desc_trib_nacional' => $this->formatter->limit(
$this->val($infNfse, 'xTribMun') ?: $this->val($infNfse, 'xTribNac'),
167,
),
'codigo_trib_municipal' => $this->val($cServ, 'cTribMun') ?: '-',
'codigo_nbs' => $this->formattedNbs($this->val($cServ, 'cNBS')),
'desc_trib_municipal' => $this->formatter->limit(trim($this->val($infNfse, 'xTribMun')), 60),
Expand Down Expand Up @@ -179,6 +185,11 @@ public function buildData(array $nfse): array
],

'tributacao_federal' => [
// NT008 note 6: optional PIS/COFINS line is present only
// for actual issue competence through calendar year 2026.
'mostrar_linha_2026' => $this->showFederalDetailsForCompetence(
$this->val($infDps, 'dCompet'),
),
'irrf' => $this->currencyOrDash($this->val($tribFed, 'vRetIRRF')),
'cp' => $this->currencyOrDash($this->val($tribFed, 'vRetCP')),
'csll' => $this->currencyOrDash($this->val($tribFed, 'vRetCSLL')),
Expand Down Expand Up @@ -417,6 +428,17 @@ private function purposeLabel(string $value): string
};
}

private function showFederalDetailsForCompetence(string $competence): bool
{
// Do not use today's date: printing an older authorized invoice
// must reproduce the display rules for its original competence.
if (preg_match('/^(\\d{4})-\\d{2}-\\d{2}$/D', $competence, $matches) !== 1) {
return false;
}

return (int) $matches[1] <= 2026;
}

private function pisCofinsRetentionLabel(string $value): string
{
return match ($value) {
Expand Down
4 changes: 3 additions & 1 deletion src/Danfse/HTMLTemplate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,11 +366,13 @@
<td><span class="label">Contribuição Previdenciária - Retida</span><span class="value"><?= $data['tributacao_federal']['cp'] ?></span></td>
<td><span class="label">Contribuições Sociais - Retidas</span><span class="value"><?= $data['tributacao_federal']['csll'] ?></span></td>
</tr>
<tr>
<?php if ($data['tributacao_federal']['mostrar_linha_2026']): ?>
<tr class="federal-competence-2026">
<td><span class="label">PIS - Débito Apuração Própria</span><span class="value"><?= $data['tributacao_federal']['pis'] ?></span></td>
<td><span class="label">COFINS - Débito Apuração Própria</span><span class="value"><?= $data['tributacao_federal']['cofins'] ?></span></td>
<td colspan="2"><span class="label">Tipo de retenção PIS/COFINS/CSLL</span><span class="value"><?= $data['tributacao_federal']['descricao_retencao'] ?></span></td>
</tr>
<?php endif; ?>
</table>
</div>

Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/Danfse/DanfseGoldenReferenceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public function testLongOfficialDescriptionsUseStableSixtyCharacterSummary(): vo

$data = (new DanfseTemplate())->buildData($nfse);

self::assertSame(63, mb_strlen($data['servico']['desc_trib_nacional']));
self::assertSame(170, mb_strlen($data['servico']['desc_trib_nacional']));
self::assertSame(63, mb_strlen($data['servico']['desc_trib_municipal']));
self::assertStringEndsWith('...', $data['servico']['desc_trib_nacional']);
self::assertStringEndsWith('...', $data['servico']['desc_trib_municipal']);
Expand Down
34 changes: 34 additions & 0 deletions tests/Unit/Danfse/DanfseTemplateTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,40 @@ public function testAuthorizedMunicipalTotalsUseNfseValuesNotDpsTaxFlags(): void
self::assertSame('R$ 630,00', $data['tributacao_municipal']['issqn_apurado']);
}

public function testMunicipalTaxDescriptionWinsButNationalIsFallback(): void
{
$nfse = $this->fixtureNfseData();
$nfse['infNFSe']['xTribNac'] = 'Descricao nacional sintetica';
$nfse['infNFSe']['xTribMun'] = 'Descricao municipal sintetica';

$template = new DanfseTemplate();
self::assertSame('Descricao municipal sintetica', $template->buildData($nfse)['servico']['desc_trib_nacional']);
self::assertStringContainsString('Descricao municipal sintetica', $template->render($nfse, new DanfseConfig()));
self::assertStringNotContainsString('Descricao nacional sintetica', $template->render($nfse, new DanfseConfig()));

unset($nfse['infNFSe']['xTribMun']);
self::assertSame('Descricao nacional sintetica', $template->buildData($nfse)['servico']['desc_trib_nacional']);
}

public function testFederalDetailRowFollowsOriginalFiscalCompetence(): void
{
$nfse = $this->fixtureNfseData();
$template = new DanfseTemplate();

$nfse['infNFSe']['DPS']['infDPS']['dCompet'] = '2026-12-31';
self::assertTrue($template->buildData($nfse)['tributacao_federal']['mostrar_linha_2026']);
self::assertStringContainsString('class="federal-competence-2026"', $template->render($nfse, new DanfseConfig()));

$nfse['infNFSe']['DPS']['infDPS']['dCompet'] = '2027-01-01';
self::assertFalse($template->buildData($nfse)['tributacao_federal']['mostrar_linha_2026']);
$html = $template->render($nfse, new DanfseConfig());
self::assertStringNotContainsString('class="federal-competence-2026"', $html);
self::assertStringContainsString('Contribuições Sociais - Retidas', $html);

unset($nfse['infNFSe']['DPS']['infDPS']['dCompet']);
self::assertFalse($template->buildData($nfse)['tributacao_federal']['mostrar_linha_2026']);
}

public function testDescriptionPreservesNewlinesWithoutRenderingMarkup(): void
{
$nfse = $this->fixtureNfseData();
Expand Down
Loading