Repository navigation
test(nfse): eliminate flaky cross-company closing receipt-key collision - #494
Merged
vitormattos merged 1 commit intoOct 14, 2026
Merged
Conversation
…regression Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This was referenced Oct 14, 2026
vitormattos
deleted the
test/nfse-deterministic-cross-company-closing-r
branch
October 14, 2026 19:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Falha comprovada
A execução Feature do PR #488 terminou com falha em
CompetenceClosingReportTest::testClosingAndCsvExcludeForeignCompanyFiscalDocuments. O gerador de fixtures produziachave_acessocomo um dígito aleatório de 1 a 8 repetido 50 vezes. Os recibos de duas empresas podiam, portanto, receber a mesma chave (probabilidade 1/8), fazendo o teste de ausência de chave falhar apesar de a consulta permanecer corretamente isolada.Correção
Permite fornecer
chave_acessodeterminística ao helper privado de testes e utiliza chaves distintas para as duas empresas no teste de isolamento, com assert explícito de distinção. Não altera implementação, dados fiscais reais, contratos nem regras de autorização. Evita corrigir falsamente o código de produção para satisfazer uma asserção aleatória.Verificação
Feature do fechamento por competência, demais shards, PHPUnit, Psalm, REUSE, lint e browser aplicáveis. Nenhuma emissão real. Commit Conventional Commits com DCO e assinatura criptográfica via Git Signing MCP. Merge apenas pelas regras nativas (sem bypass ou squash).