Repository navigation
feat(nfse): confirm existing tax fiscal associations per company (#431) - #488
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…ofiles Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
force-pushed
the
feat/tax-association-admin-431-20261014
branch
from
October 14, 2026 19:09
eef3679 to
6f1aef2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entrega
Tela compacta na configuração NFS-e para revisar e confirmar impostos Akaunting existentes, sem cadastro automático, mudança de alíquota, motor tributário ou novo onboarding. Reaproveita
TaxFiscalAssociationStoree as enumerações fiscais da #428.tax_idvinculados à empresa ativa.Sem alterações no Core, nas notas emitidas ou nos cálculos da #429. Commit assinado com DCO verificado. Refs #431 e #426.
CI deve aprovar antes de merge; registrar captura de tela com dados sintéticos na revisão visual.
Falha intermitente identificada na integração
A CI de integração com a
mainapresentou falha emCompetenceClosingReportTest::testClosingAndCsvExcludeForeignCompanyFiscalDocuments. A falha foi reproduzida com chaves sintéticas iguais por colisão do gerador de fixtures (random_int(1, 8)repetido 50 vezes); não demonstrou vazamento fiscal. A correção isolada e determinística está no PR #494, cuja CI passou. Revalidar os checks de integração desta branch depois que #494 for integrado. Não aumentar timeouts, ignorar asserções nem aprovar este PR com teste falhando.