Deprecate message - #48
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a deprecation notice to the app-ssh-agent repository and migrates the Python scripts from Python 2 to Python 3. The deprecation notice directs users to alternative solutions (app-openpgp and app-security-key) and includes a detailed comparison table of different SSH methods.
Changes:
- Added deprecation warning with migration guidance to alternative Ledger SSH solutions
- Migrated Python 2 code to Python 3 (string/bytes handling, print statements, threading module)
- Added requirements.txt with ledgerblue dependency
- Added --verbose flag to getPublicKey.py
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| README.md | Added deprecation warning banner, comparison table for SSH alternatives, and updated documentation references |
| getPublicKey.py | Migrated to Python 3: updated string/bytes handling, removed unused import, added verbose flag |
| agent.py | Migrated to Python 3: replaced thread with threading module, updated string/bytes handling and print statements |
| requirements.txt | Added ledgerblue dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cedelavergne-ledger
force-pushed
the
cev/deprecate
branch
from
February 6, 2026 12:54
321ecaf to
11527c5
Compare
cedelavergne-ledger
force-pushed
the
cev/deprecate
branch
from
February 6, 2026 13:08
11527c5 to
c336d05
Compare
iartemov-ledger
approved these changes
Feb 6, 2026
This was referenced Feb 6, 2026
romanz
added a commit
to romanz/trezor-agent
that referenced
this pull request
Feb 7, 2026
https://github.com/LedgerHQ/app-ssh-agent has beed deprecated in LedgerHQ/app-ssh-agent#48.
This was referenced Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.