Conversation
|
|
||
| prepare: | ||
| @mkdir -p bin obj debug dep | ||
| pip install -r requirements.pip |
There was a problem hiding this comment.
This is the only actual change in this file ;)
There was a problem hiding this comment.
then why don't you remove the other changes in the commit? they are just noise
There was a problem hiding this comment.
@knocte The other changes are removing the "noise" left here through the time. Unfortunately atm I don't have any editor set up to leave that "noise" in files I edit. If You can't use this PR because of that feel free to reuse the change We discuss here in Your own, new PR.
There was a problem hiding this comment.
I'm not the maintainer of this project, I just commented to help you. Maybe your PR didn't get merged because of this? You don't make style changes in the same commit as where you're fixing a problem, if you want your PR merged. Read this http://tirania.org/blog/archive/2010/Dec-31.html
There was a problem hiding this comment.
Anyway there are now conflicts, so you would need to rebase.
There was a problem hiding this comment.
RE @knocte -- #4 (comment) :
Ty, for advise and link. I'll definitely read it, it looks interesting.
Checking the conflict probably tonight
There was a problem hiding this comment.
Actually the reason for the need of a rebase is because of including style changes ;) if they hadn't been there, then this PR wouldn't have had conflicts ;)
|
Not needed |
3 participants
This will make it easier for newcomers to play