[cristim]

Supersedes #764

#764 was stacked on #763's branch (fix/ux-confirm-dialogs). #763 was squash-merged to main as 2360338, so #764's branch still carries #763's pre-squash commits and is BLOCKED. A force-push is not allowed, so this PR replays #764's own five commits onto current main (cherry-pick, no force-push). Intent and content are unchanged; nothing was added.

Commits (original messages, in order)

• 17b39ed (was db11d3d) fix(frontend): money confirms state what is bought and how much
• 919881d (was 0857a56) fix(frontend): keep the exact offering id in the RI exchange confirm
• e783e1c (was fc4c1c2) fix(frontend): label approval-path amounts and flag unreported monthly fees
• d015b93 (was 108fddb) test(frontend): e2e asserts instance type and offering id in the exchange confirm
• 27d5801 (was 7d66c1a) fix(frontend): recognise the Azure upfront and monthly payment spellings

Conflict resolutions: none; all five cherry-picks applied cleanly.

Equivalence

git diff origin/fix/ux-confirm-dialogs origin/fix/ux-money-confirms (#764 vs its base) and git diff origin/main HEAD (this PR) are identical apart from index hash lines (632 lines each, no differing hunks).

What

Original description from #764: shared commitmentSummary.ts stat band and commitment lines; Execute now, Run now and RI exchange confirms state what is bought and how much (Total over term shows "Not reported" instead of a fake $0).

Refs #707, #709, #701, #711.

Verification (frontend/, on this head)

• npm ci 0, tsc --noEmit 0, jest 100 suites / 3168 passed, 1 skipped (exit 0), eslint 0 errors (exit 0).
• Visual evidence for the unchanged diff is on fix(frontend): money confirms state what is bought and how much #764 (round 3 approved at 7d66c1a); delta review against that SHA requested.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

• Run on-demand review

_{This review includes 10 billable files and costs up to $2.50.}

• Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 46 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 86 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository: LeanerCloud/cloud-commitments-platform/.coderabbit.yaml
• Review profile: CHILL
• Plan: Essentials
• Run ID: de98d275-751f-4f8c-89ad-08b62109b547

---

📥 Commits

Reviewing files that changed from the base of the PR and between 6f5a618 and 27d5801.

---

📒 Files selected for processing (10)

• frontend/src/__tests__/commitmentSummary.test.ts
• frontend/src/__tests__/plans.test.ts
• frontend/src/__tests__/purchase-modal-submit.test.ts
• frontend/src/__tests__/riexchange.test.ts
• frontend/src/app.ts
• frontend/src/commitmentSummary.ts
• frontend/src/plans.ts
• frontend/src/riexchange.ts
• frontend/src/styles/components.css
• frontend/tests-e2e/ri-exchange-confirmation.spec.ts

---

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}

[cristim]

Delta review (cloud-commitments-coordinator subagent): equivalence to #764 @7d66c1a9

APPROVE at 27d5801.

1. Parent chain: merge-base with origin/main is 16aec29 (ancestor of origin/main, fix(server): wait for background DB init before returning from shutdown #691). fix(frontend): money confirms state what is bought and how much #781 adds exactly 5 commits; subjects match d7fb436..7d66c1a one-to-one (db11d3d, 0857a56, fc4c1c2, 108fddb, 7d66c1a).
2. Patch equivalence: git diff d7fb436f 7d66c1a9 and git diff 16aec294 27d58012, index lines stripped, are both 622 lines and diff reports no difference (10 files).
3. Main overlap (e5ac75d..16aec29 vs the 10 files): plans.ts, plans.test.ts, ri-exchange-confirmation.spec.ts. The spec and the confirmDialog part of plans.* are fix(frontend): confirm dialog focuses the safe action and is accessible #763's own squash (2360338, no diff vs d7fb436 for the spec). Real new overlap is fix(plans): say that cancelling a scheduled purchase also disables its plan #770 (225ad35), which edits the plans.ts "disable" case dialog copy and its test; fix(frontend): money confirms state what is bought and how much #764 edits the "run" case (new runPlannedPurchaseNow, import). Different hunks and behaviours, cherry-pick clean; fix(plans): point plan-step refusal messages at #631 #768 touches only plans.test.ts text. No semantic interaction.
4. Approval: rv-ux-visual round 3 on fix(frontend): money confirms state what is bought and how much #764 is headed "PR fix(frontend): money confirms state what is bought and how much #764 at 7d66c1a", "Verdict: approved". It notes green CI was still open then, so CI on 27d5801 and the repo review gate (verdict, SHA, local verification recorded on fix(frontend): money confirms state what is bought and how much #781) still apply. I did not run jest/e2e here.

[cristim]

Independent review (rv-ux-visual): PR #781 at 27d5801273d220e0def606141c8f4c82dbc213a8

Verdict: approved. This is #764 replayed onto main, and I approved #764 at 7d66c1a after three rounds. CI status at this SHA is below.

• Content check: fix(frontend): money confirms state what is bought and how much #764's own patch (GitHub compare d7fb436...7d66c1a) and this PR's patch (6f5a618...27d5801) are byte-identical, hunk headers included, once index lines are ignored. The "replayed, nothing added" claim holds.
• New combination: main gained fix(frontend): confirm dialog focuses the safe action and is accessible #763 (squash of the approved d7fb436), fix(plans): say that cancelling a scheduled purchase also disables its plan #770 and fix(plans): point plan-step refusal messages at #631 #768 since then; fix(plans): say that cancelling a scheduled purchase also disables its plan #770 also edits plans.ts. I re-ran the live checks on a production build of 27d5801 with the same mock:
  • All 10 money-confirm cases (approval, Execute now and Run now at 1280/768/390, plus the no-recommendations step) have the same title, body and initial focus as approved fix(frontend): money confirms state what is bought and how much #764.
  • The Azure all-upfront Run now shows "Monthly: Not reported" with no fee hint, and the line reads "All upfront".
  • Two clicks on Run now open 1 dialog and send 1 POST …/run.
  • The fix(plans): say that cancelling a scheduled purchase also disables its plan #770 "Cancel this scheduled purchase?" dialog now opens on "Keep it" at all three widths, and a reflex Enter sends no DELETE (fix(frontend): confirm dialog focuses the safe action and is accessible #763's safe focus now applies, as noted in my fix(plans): say that cancelling a scheduled purchase also disables its plan #770 review).
• Pages: this PR's CSS only adds .commitment-summary-* classes, which are used inside dialogs, so it does not change any page. Page-level diffs were 33/33 at 0.00% for the identical patch in fix(frontend): money confirms state what is bought and how much #764 round 3.

CI at this SHA: 26/26 green, including Build frontend (jest) and Playwright Chromium.

Housekeeping: #764 can be closed as superseded by this PR once it merges (or now).

[cristim]

Merged as 6248db2 (squash, match-head 27d5801). Gate: rv-ux-visual round-3 approval of #764 at 7d66c1a carried over; equivalence review at 27d5801 found diffs identical (comment 6081466742). CI 27/27 green, CLEAN/MERGEABLE. Local at 27d5801 (git archive): npm ci 0, tsc --noEmit 0, npm test --silent 0 (3168 passed, 1 skipped), npm run lint 0 (0 errors, 125 warnings).