Skip to content

fix(frontend): refuse a purchase when a recommendation has no payment option - #643

Merged
cristim merged 1 commit into
mainfrom
fix/purchase-payment-no-silent-default
Oct 6, 2026
Merged

cristim merged 1 commit into
mainfrom
fix/purchase-payment-no-silent-default

Conversation

@cristim

@cristim cristim commented Oct 6, 2026

Copy link
Copy Markdown
Member

No description provided.

… option

handleExecutePurchase defaulted a missing payment to all-upfront, the most
cash-intensive schedule, on the purchase submission path. Block the
submission with an error toast before the confirm dialog and the POST.

Closes #431
@cristim cristim added priority/p2 Backlog-worthy severity/medium Moderate harm effort/xs Trivial / one-liner type/bug Defect labels Oct 6, 2026
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 2 billable files and costs up to $0.50.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 18 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 69 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: LeanerCloud/cloud-commitments-platform/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 11897247-340f-4067-acd3-3eedfe34a638
📥 Commits

Reviewing files that changed from the base of the PR and between feec673 and 81060ac.

📒 Files selected for processing (2)
  • frontend/src/__tests__/purchase-execution-toast.test.ts
  • frontend/src/app.ts
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@cristim
cristim merged commit e96f5ae into main Oct 6, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/xs Trivial / one-liner priority/p2 Backlog-worthy severity/medium Moderate harm type/bug Defect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant