[cristim]

Summary

Bumps all four cloud-commitments-go modules from 61111428a353 to go main 790f369f (v0.0.0-20261105183508-790f369f4822), and folds in the platform change that #688 requires (#1789). This PR is a dependency enabler, outside the platform PR cap per the coordinator.

The go changes it brings in:

go PR	Effect on the platform
#682	Fractional Cost Explorer RI quantities are rounded down, with their costs scaled. No platform test changed.
#684	A purchase count above int32 is refused before any AWS call.
#685	GCP lists only live commitments. There is no platform caller outside tests.
#686	Adds the optional ObservedCommitmentRateCapability. Nothing reads it yet; T7 (ui-fix-1) will.
#688	RI exchange targets need the source RI's offering type. Without #1789, every auto-exchange and ladder-reshape lookup fails.
#691	Commitment rates are fetched per layer, so one missing rate holds only its layer. Only the EC2 Instance SP layer is listed, so behaviour is unchanged.

Minimum version selection also raises a few transitive AWS SDK and Google API modules that the library requires. There are no replace directives, and go mod verify passes.

#1789 (cherry-picked from claude-ui-fix-2, authorship kept) forwards the source RI's offering type in newConvertibleOfferingLookup and convertForAutoExchange (internal/server/handler_ri_exchange.go). The zone-test fixture now carries Partial Upfront, and the zonal test asserts the type reaches DescribeReservedInstancesOfferings.

Tests

• Before Pass the source RI's offering type to the exchange target lookup (go#553 follow-up) #1789: at the new pin, the full unit suite failed exactly two tests, TestExecuteRIExchangeReshape_{Zonal,Regional}... in internal/server, both with "offering lookup must reach the provider". With Pass the source RI's offering type to the exchange target lookup (go#553 follow-up) #1789 both pass.
• Evidence from ui-fix-2: removing the forwarding fails MapsEveryField and CarriesOfferingType.
• This branch:
  • go build ./... passes, and so does go vet on server, api, config, purchase and scheduler.
  • go test ./internal/... passes.
  • go test -tags integration passes for internal/api, internal/config and internal/server.
  • Everything ran throttled.

Closes #1789

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 46 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: LeanerCloud/cloud-commitments-platform
• Branch: chore/bump-cloud-commitments-go-790f369f
• File: .coderabbit.yaml
• Commit: cce1921
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: fbaa6c48-5c4b-43b6-950c-59f6c29da476

Commits

Reviewing files that changed from the base of the PR and between da8c78e and cce1921.

Files ignored due to path filters: 1

• go.sum is excluded by !**/*.sum

Files selected for processing: 3

• go.mod
• internal/server/handler_ri_exchange.go
• internal/server/ri_exchange_zone_test.go

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[cristim]

APPROVED cce1921 by claude-qa-ui-3

Cold review of the full diff (the go pin bump plus the #1789 OfferingType forwarding).

Checked

• Both auto-exchange paths forward OfferingType (internal/server/handler_ri_exchange.go:157 and :361). The manual quote path is unchanged.
• The pin bump's API changes are absorbed. The ladder change is additive.

Mutation probe: removing the forwarding fails TestConvertForAutoExchange_CarriesOfferingType, TestNewConvertibleOfferingLookup_MapsEveryField and TestExecuteRIExchangeReshape_ZonalRIForwardsAvailabilityZone.

Local verification (macOS, at this SHA, throttled)

• go mod verify and tidy: clean. Build and vet: OK.
• Unit tests: server, api, config and purchase pass.
• go test -tags integration for server, api and config (Postgres testcontainers): pass.
• golangci-lint v2.10.1: 0 issues.

Non-blocking note: the manual quote's targetOfferingsForSource now reports the #677 page-cap truncation as a generic 500. That is behavior from before this PR; it could be a typed 4xx in a follow-up.

[cristim]

APPROVED cce1921 by claude-qa-ui-4

Cold review of the cloud-commitments-go bump 61111428..790f369f (19 commits) plus the OfferingType forwarding.

go change	platform call site	status
FindConvertibleOfferingParams.OfferingType required (#688)	internal/server/handler_ri_exchange.go:150-158	set from p.OfferingType; removing it fails TestNewConvertibleOfferingLookup_MapsEveryField and the zonal/regional reshape tests
RIMetadataInfo.OfferingType (#688)	handler_ri_exchange.go:355-362 (auto-exchange and reshape), ladder_write.go:78	set from inst.OfferingType (filled by go ec2/client.go:878); removing it fails TestConvertForAutoExchange_CarriesOfferingType and the reshape tests
GetCommitmentRates per layer, refuses unusable rates (#691)	internal/server/handler_ladder.go:339-342	the run errors; replacing the error with an empty map fails TestExecuteLadderRun_RateFetchErrorIsErrored
int32 count refusal, ErrRefusedBeforePurchase (#684, #673/#672)	internal/purchase/execution.go:1230-1243	returned as "purchase failed: %w"
ListTargetOfferings truncation error (#677)	internal/api/handler_ri_exchange.go:170-180	returned as a 500
Azure retry ErrOutcomeUnknown (#679)	internal/api/ri_exchange_refusals.go:26-46	exchange currency refusals come from CheckCurrency, so no change

• Every builder of an exchange lookup goes through newRIExchangeClients (handler_ri_exchange.go:58-69) or ladder_write.go:47; no other builder found. A failed target lookup stays visible as a Skipped reason with the error text (go pkg/exchange/auto.go:360-366).
• No consumed cancel-spelling change (go delta: one GCP comment and the SDK enum; platform diff: none).
• go mod verify passes and go mod tidy leaves no diff; only the root go.mod uses the module.
• Local, throttled (GOMAXPROCS=4, -p 2): build and vet pass; unit ./internal/... 12326 pass, 0 fail; integration api 6138, config 1788, server 861, 0 fail. Merged with current main (e86860c) in a scratch commit: clean merge, build OK, server/purchase/api unit 7221 pass. CI green, including Lint Code.

Non-blocking:

• The PR body names internal/api for the forwarding; the file is internal/server/handler_ri_exchange.go (:157, :361). The body's table lists 6 go PRs; the range also includes fix(server): StartHTTPServer shutdown does not wait for background DB init #664-fix(azure): flag historical purchase amounts recorded in lookback-window units #669, fix(frontend): say when a pending row has no recorded creator under four-eyes #672, fix(api): refuse direct RI exchange execution while 4-eyes mode is on #673, feat(api): scope-aware SQL totals for the History summary cards #675, fix(purchase): API-key-created pending purchases have a null creator and can never be approved under four-eyes #677-sec(ri-exchange): auto mode and nil-creator rows bypass 4-eyes; tighten #673 tests #679, fix(api): enforce permission Constraints on purchase revoke #681.
• No platform test drives ErrRefusedBeforePurchase or an over-int32 count through execution.go:1230-1243; swallowing it there passes the purchase suite. Predates this PR.

[cristim]

Merged at head cce1921 as 04f3515. Gate evidence:

• Cold approvals at the head: claude-qa-ui-3 and claude-qa-ui-4.
• CI green at the head. 0 unresolved threads. Merge state CLEAN. No autofix commits.
• Combo on main e86860c + cce1921 (main unchanged at merge): build and vet pass; unit tests for internal/server, api, purchase, config and scheduler pass; the internal/server integration suite passes.
• This is a code-only dependency bump, so the deploy hold for migration and terraform changes doesn't apply.
• Pass the source RI's offering type to the exchange target lookup (go#553 follow-up) #1789 is closed by this merge.
• Next pin bump (bump 2): after go#554, with ui-fix-2's fix(ladder): accept both canceled spellings before the go#554 pin bump #1792 commits; any pin past go#694 must also carry fix(purchase): route Azure Redis purchases to managedredis before the go pin includes go#694 #1801.