[IAmJSD]

The Plans list picked the "Ramp Schedule" label from the stored ramp type alone, so a plan stored as weekly 20% every 7 days showed "Weekly 20%" while Edit opened it as Custom 20% / 7 days, and a weekly 25% every 14 days plan showed "Weekly 25%", hiding the interval. The auto-generated plan name also rounded custom step counts up ("(4 steps)" for a 3-step 30% schedule). This PR labels ramps with the same preset-equality rule Edit uses and counts steps the way the backend does.

Closes #1185

What changed

• frontend/src/plans.ts:
  • formatBackendRampSchedule now uses rampRadioValue, the same preset-equality check Edit uses. It shows a preset name only when type, percent and interval all match PRESET_RAMPS, and otherwise "Custom N% every D days" ("day" when D is 1; "Custom N%" if no interval is stored). Unknown types still show the raw type. This is the only render site for the ramp label.
  • PRESET_RAMPS gains a label field so preset names and matching stay together.
  • generatePlanName uses Math.max(1, Math.floor(100 / pct)), matching internal/api/types.go buildCustomRampSchedule and plan-schedule-intent.ts, and says "1 step" in the singular.
• New frontend/src/__tests__/plans-ramp-label.test.ts.

Why this approach

Reusing rampRadioValue means the list and the Edit dialog can't disagree again, which is the fix the issue proposes. The existing preset label text ("Weekly 25%", "Monthly 10%") is kept, so properly stored preset plans look exactly as before.

Screenshots

Before is main (a14dc8f2), after is this branch. Both are headless Chromium at 1440x900 against the repo's mocked e2e API, showing /plans with three mocked plans.

Before	After

• Before: plans stored as weekly 20%/7d and weekly 25%/14d list as "Weekly 20%" and "Weekly 25%", the same label as the real 25%/7d preset, with the 14-day interval hidden. After: they read "Custom 20% every 7 days" and "Custom 25% every 14 days", matching what Edit opens, and the real preset still reads "Weekly 25%".

Verification

Run on this branch's head b98e8350 on top of main a14dc8f2:

• Lint: 0 errors (142 existing warnings). Typecheck and build pass.
• Jest: 110 suites, 3496 passed, 1 skipped. New tests (10): for stored weekly 25/7, monthly 10/30, weekly 20/7, weekly 25/14, custom 25/7, custom 50/1 and immediate, the list label and the radio Edit opens agree; the generated name for custom 30% says "(3 steps)", 25% "(4 steps)", 60% "(1 step)". On main a14dc8f2, 5 of the 10 fail (weekly 20/7, weekly 25/14, the "1 days" case, 30% naming and 60% naming). Randomized run: 10/10.
• Playwright: 157 passed. No new spec (label text only; jest covers list/Edit agreement through the real index.html).
• git-secrets scan clean (planted key flagged); allowlist test 137 pass.

Notes for review

• Non-preset ramps read "Custom 20% every 7 days" even when stored with type weekly. That matches Edit, as the issue asks, but "Weekly 20%" for 7-day intervals is an alternative. The longer text wraps to two lines in the Ramp Schedule cell at 1440px (see the after shot).
• Small extras beyond the issue: singular "1 day" and "1 step".

Overlaps

plans.ts is also touched by #18, #181, #37, #727, #737 and #739. Only #739 is close: it edits around lines 1037 and 1136-1140, next to formatBackendRampSchedule (1060-1070) and its call site at 1144. A textual conflict is unlikely, but the merge should be checked. Those PRs will be opened alongside this one and merged in sequence, with conflicts resolved on the later branch.

Note for the UI owner

This changes UI code that @cristim owns. IAmJSD reviewed the before/after screenshots and asked for it to be merged; any design point you disagree with can be a follow-up.

🤖 Generated with Claude Code

[IAmJSD]

Independent review (IAmJSD's agent, fresh context, given only the diff, the issue and the PR text): APPROVE b98e8350411f00a85a36fb9b6282e32d53e2c921

Blocking:

• none
  Non-blocking:
• frontend/src/plans.ts:1147,1066: the label is still interpolated into innerHTML without escapeHtml, and the unknown-type branch returns raw ramp.type. This is pre-existing and low risk because the backend enforces ValidRampScheduleTypes, but wrapping the call in escapeHtml would be cheap.
  Attacked: Checked that the label now derives from rampRadioValue, the same function editPlan uses, so list and Edit cannot disagree. Checked that custom 25/7 (a type mismatch with the preset) reads Custom. Checked the new step count against buildCustomRampSchedule (int(100/stepPercent), minimum 1) and plan-schedule-intent.ts (floor), so they match. Checked that PRESET_RAMPS values mirror config.PresetRampSchedules. Closes fix(plans): plan list ramp label ignores percent/interval and disagrees with Edit #1185 is justified: both the label and the name items from the issue are covered.

[coderabbitai]

Warning

Review limit reached

• Run on-demand review

_{This review includes 2 billable files and costs up to $0.50.}

Or wait 59 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: LeanerCloud/cloud-commitments-platform
• Branch: main
• File: .coderabbit.yaml
• Commit: 61be5b6
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 7e1153d2-ae28-4af4-9615-553723dcaff3

Commits

Reviewing files that changed from the base of the PR and between 61be5b6 and b98e835.

Files selected for processing: 2

• frontend/src/__tests__/plans-ramp-label.test.ts
• frontend/src/plans.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[IAmJSD]

Local verification at b98e8350 merged onto current main (84b53f5a; merge-tree 68aba35f; Linux, Node, headless Chromium):

• This branch's own checks passed at this head: lint, typecheck, build, the full jest suite, the full Playwright e2e suite, and the git-secrets checks (see Verification in the PR body).
• The combined tree of every UI PR in this merge wave (tree 89dd34d8, main plus 46 PRs) passes npm ci, lint, typecheck, build, jest (1 skipped, 3914 passed, 3915 total), and the full Playwright suite (208 passed).
• CI is green on b98e8350 (CI Success, Run pre-commit hooks).
• The independent review above approves this exact head.
• Nothing was applied to any cloud.

[IAmJSD]

Marked ready and merged by IAmJSD's agent, at IAmJSD's request (IAmJSD reviewed the before/after screenshots; cristim is traveling), after the independent review and local verification above, all at b98e8350.