[IAmJSD]

A pending execution with no recommendations comes back from /api/history with count 0, term 0, "0 commitment(s)", provider/region "multiple" and $0 costs, and the Purchases page (Approval queue and Purchase History) printed those as data. A real mixed-term basket also showed "0 Years". On Plans, a pending scheduled purchase past its date showed a plain "Pending" badge with no sign it missed its run. This PR guards those renders and flags overdue planned purchases with a next action.

Closes #181

What changed

• Purchases (e63a94b9): new frontend/src/lib/purchase-row-guards.ts (hasNoCommitments for count 0, isRealTerm, isPastScheduledDate, and the shared "No recommendations attached" copy). In frontend/src/history.ts, both the Purchase History table and the Approval queue render a no-commitment row with muted dashes for provider, service, region, count, term, payment, costs and savings, and "No recommendations attached" in the Type (history) or Service (queue) cell. A 0 term renders as a dash everywhere, including the Term column-filter labels. Real rows keep main's upfront cell with its "(in monthly)" note (chore(frontend): low money-path findings from the 2026-09-02 audit #318); a no-commitment row gets a muted dash in its place.
• Plans (23a900a1): frontend/src/plans.ts renderPlannedPurchaseRow adds an "Overdue" badge (the existing status-badge badge-danger classes, as on plan cards) next to Pending/Notified when scheduled_date is before today, plus a hint "Not run on its date. Run now or pause." (or just "Not run on its date." without run permission). frontend/src/styles/tables.css adds .status-badges and .overdue-hint.
• Tests: src/__tests__/purchases-placeholders-181.test.ts and src/__tests__/plans-overdue-181.test.ts.

Why this approach

The backend contract for these synthetic rows is deliberate (handler_history.go comments say a 0 term should render blank), so the guard belongs in the renderer, as the issue asks ("guard the render regardless"). count == 0 is the reliable marker: synthetic rows set count to the number of recommendations, and a real purchase never has 0. formatTerm itself is unchanged (a unit test pins formatTerm(0) == '0 Years' and other callers pass real terms); the call sites that can see 0 are guarded instead. The overdue check compares YYYY-MM-DD text against the local date to avoid the UTC off-by-one that new Date('YYYY-MM-DD') causes. On Plans, "Various (Multiple)", 0 count and $0 for no-recommendation steps and the "0 Years" term were already handled by #609 and the existing term > 0 guard.

Screenshots

Screenshots were taken before this branch was merged with main; before = main at a14dc8f. After is this branch. Both are headless Chromium at 1440x900 against the repo's mocked e2e API.

Before	After

1. /purchases/history with an empty pending execution, a mixed-term basket and a normal row. Before: the empty execution shows "Multiple", Count 0, "0 commitment(s)", "0 Years" and $0 in both the Approval queue and Purchase History, and the mixed-term basket shows "0 Years". After: the empty execution shows dashes and "No recommendations attached" in both tables, the mixed-term basket keeps its real count and costs with a dash for term, and the normal row is unchanged.
2. /plans planned purchases with one pending step dated 2026-09-15 (past) and one in 2027. Before: both show only "Pending". After: the past step shows "Pending" plus "Overdue" with "Not run on its date. Run now or pause."; the future step is unchanged.

Verification

Run on this branch's head 686288c2, from frontend/:

• Merged with main at 5b52c4e; conflicts in frontend/src/history.ts resolved, see the merge commit.
• npm run lint: 0 errors. Typecheck and build pass.
• Jest: 3873 of 3874 passed, 1 skipped.
• New purchases-placeholders-181.test.ts (6): the helpers including date edge cases; history and Approval queue rows driven through loadHistory with the real formatters; the mixed-term basket.
• New plans-overdue-181.test.ts (3): overdue vs future pending, the copy without run permission, paused rows not flagged.
• Before the merge, both new suites passed with --randomize.
• Playwright via e2e-local.sh: 200 passed.
• Secrets scan: clean, planted key flagged. scripts/test-git-secrets-allowlist.sh: 137 PASS, 0 FAIL.

Notes for review

• Copy to check: "No recommendations attached" (reused from Plans, fix(plans): a plan with no matching recommendations schedules zero-count purchases instead of failing #609), the "Overdue" badge, and the hint "Not run on its date. Run now or pause."
• No-commitment rows still offer Approve/Cancel in the Approval queue. Whether an empty basket should be approvable is a backend/policy question and is not changed here.
• Overdue applies to pending and notified rows, not paused ones. Main's plan-card isPlanOverdue parses the date as UTC midnight, so in UTC-negative zones it can say "Overdue" on the scheduled day while the row here does not. Having isPlanOverdue reuse isPastScheduledDate would align them; not changed here.
• The Home upcoming-purchases widget is not changed; the issue does not name it.
• The issue's source document (docs/ui-ux-review.md) is no longer in the repo, so the fix follows the issue text.
• Split into two commits to keep each under 400 changed lines.

Overlaps

• fix(frontend): three money formatters, mixed placeholders, left-aligned money columns #739 (one money formatter and absent-value placeholder) conflicts textually in frontend/src/history.ts and also touches plans.ts and tables.css. Both change how absent values render in the same rows, so the dash style should be reconciled with whatever fix(frontend): three money formatters, mixed placeholders, left-aligned money columns #739 standardizes when combining.
• fix(frontend): status badges use four shapes and conflicting colors per status #737 (shared status badges) conflicts textually in frontend/src/plans.ts.
• Merges cleanly with the branches for fix(frontend): failed upcoming purchases fetch renders as empty state #713 and fix(frontend): getUpcomingPurchases declares an array but the API returns { purchases } #1189.

Note for the UI owner

This changes UI code that @cristim owns. IAmJSD reviewed the before/after screenshots and asked for it to be merged; any design point you disagree with can be a follow-up.

🤖 Generated with Claude Code

[coderabbitai]

Caution

Review failed

The pull request is closed.

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[IAmJSD]

Independent review (IAmJSD's agent, fresh context, given only the diff, the issue and the PR text): APPROVE 686288c29966df9f79b848b065d2ee9aedf873cf

Blocking:

• none
  Non-blocking:
• frontend/src/plans.ts:438-441 vs frontend/src/plans.ts:757-764: two "overdue" checks now disagree. The branch's isPastScheduledDate compares the YYYY-MM-DD text with the local date. Main's isPlanOverdue (plan cards) uses new Date('YYYY-MM-DD'), which parses as UTC midnight. So for a user in a UTC-negative zone, on the scheduled day the plan card says "Overdue" but that plan's pending row does not. The bug is main's; the follow-up is to have isPlanOverdue reuse isPastScheduledDate.
• frontend/src/plans.ts:439: the hint "Run now or pause." depends only on canRunPurchase, but the Pause button needs canPauseOrResumePurchase (update:purchases). A user with execute:purchases but no update:purchases is told to pause and has no Pause button.
• frontend/src/lib/purchase-row-guards.ts:41-46: for a full ISO timestamp, slice(0,10) takes the UTC date and compares it with the local date, so near midnight it can be a day off. This doesn't matter if scheduled_date is always date-only.
• frontend/src/history.ts:562 vs frontend/src/plans.ts:403-405: a placeholder in History and the Approval queue renders as a muted "-", while a Plans no-recommendation step (fix(plans): a plan with no matching recommendations schedules zero-count purchases instead of failing #609, on main) renders as a bare "—". Two dash styles for the same "no data" state; fix(frontend): three money formatters, mixed placeholders, left-aligned money columns #739 (PR 1376, still open) is meant to settle this.
• frontend/src/history.ts:1294 plus the Provider and Count column filters: an empty row's cells show "-", but the filter popover still lists the raw "multiple" or 0 for it. Only Term got a matching display label (1144-1146, 1831-1833). Cosmetic.
• frontend/src/tests/purchases-placeholders-181.test.ts:48: getAmortizeUpfront is fixed to false. Nothing tests the merged interaction with amortize on: the empty row should show a dash instead of the "(in monthly)" upfront cell, and a real row should keep the note.
  Attacked: The worktree is at the stated sha. git diff merge^2 merge equals origin/main...HEAD (6 files), so the merge added nothing outside the PR. In merge^1->merge for history.ts, all of main's newer work survived: fix(frontend): escape the remaining raw values in innerHTML templates #1318 escaped count, chore(frontend): low money-path findings from the 2026-09-02 audit #318/fix(frontend): low money-path display and SP coverage input fixes #1345 upfrontCell(p, amortize) with amortize hoisted out of the row loop, sec(frontend): low-severity RBAC and input hardening from the 2026-09-02 audit #320 four-eyes and revoke-own, the feat(frontend): de-duplicate the Purchases approval surface (Approval queue repeats Purchase History rows) #183 queue link, fix(frontend): History and Approval Queue filter popovers collide on shared column ids #281 filter scopes and the marketplace cents math. fix(frontend): impossible/placeholder values surfaced for scheduled and pending purchases #181's dashOr, NO_RECS_HTML and termCell(p) survived in both tables. There are no follow-up commits.
  merge-tree against current main 51aa5b1 (8 commits later, including fix(frontend): offer Revoke on scheduled AWS and GCP executions #1393 and fix(plans): label a plan's ramp the way Edit reads it #1396) is clean. Every interpolated value is escaped, the new constants are static, badge-danger exists and no inline styles were added. Scratch jest: 5 suites / 229 tests passed.

[IAmJSD]

Local verification at 686288c2 merged onto current main (11b372a8; merge-tree 77f0b010; Linux, Node, headless Chromium):

• This branch's own checks passed at this head: lint, typecheck, build, the full jest suite, the full Playwright e2e suite, and the git-secrets checks (see Verification in the PR body).
• The combined tree of every UI PR in this merge wave (tree dc090cc2, main plus 17 PRs) passes npm ci, lint, typecheck, build, jest (1 skipped, 4097 passed, 4098 total), and the full Playwright suite (232 passed).
• CI is green on 686288c2 (CI Success, Run pre-commit hooks).
• The independent review above approves this exact head.
• Nothing was applied to any cloud.

[IAmJSD]

Marked ready and merged by IAmJSD's agent, at IAmJSD's request (IAmJSD reviewed the before/after screenshots; cristim is traveling), after the independent review and local verification above, all at 686288c2.