Skip to content

fix(api): restore base build - drop removed Session.Role from handler_purchases_test (regression from #528) #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 1 commit into from
Jun 5, 2026
Merged

fix(api): restore base build - drop removed Session.Role from handler_purchases_test (regression from #528) #975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions internal/api/handler_purchases_guards_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,31 +54,39 @@ func TestValidatePurchaseRecommendation(t *testing.T) {
{"valid azure monthly", mutate(func(r *config.RecommendationRecord) { r.Provider = "azure"; r.Payment = "monthly" }), false},
// Legacy AWS-style tokens on Azure are normalized to Azure-canonical before validation.
{"azure accepts legacy all-upfront (coerced to upfront)", mutate(func(r *config.RecommendationRecord) {
r.Provider = "azure"; r.Payment = "all-upfront"
r.Provider = "azure"
r.Payment = "all-upfront"
}), false},
{"azure accepts legacy no-upfront (coerced to monthly)", mutate(func(r *config.RecommendationRecord) {
r.Provider = "azure"; r.Payment = "no-upfront"
r.Provider = "azure"
r.Payment = "no-upfront"
}), false},
{"azure accepts legacy partial-upfront (coerced to upfront)", mutate(func(r *config.RecommendationRecord) {
r.Provider = "azure"; r.Payment = "partial-upfront"
r.Provider = "azure"
r.Payment = "partial-upfront"
}), false},
{"azure rejects unknown token", mutate(func(r *config.RecommendationRecord) {
r.Provider = "azure"; r.Payment = "foo"
r.Provider = "azure"
r.Payment = "foo"
}), true},
// --- GCP canonical set (monthly-only) ---
{"valid gcp monthly", mutate(func(r *config.RecommendationRecord) { r.Provider = "gcp"; r.Payment = "monthly" }), false},
// Legacy tokens on GCP are all normalized to monthly.
{"gcp accepts legacy upfront (coerced to monthly)", mutate(func(r *config.RecommendationRecord) {
r.Provider = "gcp"; r.Payment = "upfront"
r.Provider = "gcp"
r.Payment = "upfront"
}), false},
{"gcp accepts legacy all-upfront (coerced to monthly)", mutate(func(r *config.RecommendationRecord) {
r.Provider = "gcp"; r.Payment = "all-upfront"
r.Provider = "gcp"
r.Payment = "all-upfront"
}), false},
{"gcp accepts legacy no-upfront (coerced to monthly)", mutate(func(r *config.RecommendationRecord) {
r.Provider = "gcp"; r.Payment = "no-upfront"
r.Provider = "gcp"
r.Payment = "no-upfront"
}), false},
{"gcp rejects unknown token", mutate(func(r *config.RecommendationRecord) {
r.Provider = "gcp"; r.Payment = "foo"
r.Provider = "gcp"
r.Payment = "foo"
}), true},
// --- General ---
{"payment case-insensitive", mutate(func(r *config.RecommendationRecord) { r.Payment = "All-Upfront" }), false},
Expand Down
2 changes: 1 addition & 1 deletion internal/api/handler_purchases_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1641,9 +1641,9 @@ func TestHandler_getPurchaseDetails_NotFound_IsClientError(t *testing.T) {
adminSession := &Session{
UserID: "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa",
Email: "admin@example.com",
Role: "admin",
}
mockAuth.On("ValidateSession", ctx, "admin-token").Return(adminSession, nil)
mockAuth.grantAdmin()

const missingID = "dddddddd-dddd-dddd-dddd-dddddddddddd"
// Simulate the DB returning a generic error (as pgx does on a missing row).
Expand Down
Loading