[cristim]

Summary

• PR sec(purchases): map GetExecutionByID not-found to 404 in getPurchaseDetails (closes #431) #528 introduced TestHandler_getPurchaseDetails_NotFound_IsClientError using Role: "admin" in a &Session{} literal, but Session.Role was removed in fix(api/purchases): base build broken - session.Role removed by #907 but still used in authorizeSessionExecuteDirect (#803) #940/Revamp authorization: group-membership-only (remove roles), require >=1 group per user #907.
• This caused go vet ./internal/api/ to fail with unknown field Role in struct literal of type Session, breaking the base build for anyone on feat/multicloud-web-frontend.
• Fix: remove the stale Role: "admin" field and add mockAuth.grantAdmin() following the established pattern used in 30+ other tests in the same file (see comment at mocks_test.go:881-897).

Changes

• internal/api/handler_purchases_test.go line 1644: remove Role: "admin" from adminSession literal; add mockAuth.grantAdmin() so HasPermissionAPI is properly stubbed.
• internal/api/handler_purchases_guards_test.go: gofmt formatting only (semicolons split to newlines, caught by pre-commit hook).

Verification

• go vet ./internal/api/: no issues
• gofmt -l: clean
• go build ./...: success
• go test ./internal/api/ -count=1: 1458 passed
• SKIP=terraform_validate pre-commit run --all-files: all passed

Test plan

• CI passes on this branch
• go vet ./internal/api/ returns 0 issues
• TestHandler_getPurchaseDetails_NotFound_IsClientError passes and still asserts the 404 ClientError regression for sec(purchases): GetExecutionByID returns error on not-found, causing 500 instead of 404 — leaks execution UUID existence to unauthenticated callers #431

[coderabbitai]

Warning

Review limit reached

@cristim, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 38 minutes and 53 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 796b4cf4-ad48-443f-aa43-4ef404e8a8f4

📥 Commits

Reviewing files that changed from the base of the PR and between 62c8f63 and 898d581.

📒 Files selected for processing (2)

• internal/api/handler_purchases_guards_test.go
• internal/api/handler_purchases_test.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/hotfix-session-role-528

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cristim]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.