feat(packages): check-release --staged classifies pre-bump findings as expected (#227 E3#6) - #239
Merged
Merged
Conversation
chrisdpurcell
marked this pull request as ready for review
September 1, 2026 20:27
Between a landed payload cut and release prep, `.standards/`, the catalog projection and the project version lag the catalog by design, so check-release reported PC-RELEASE-LEVEL, PC-RELEASE-PROJECTION and PC-RELEASE-PROJECT-VERSION and exited 1 on a tree that was correct for its phase. `--staged` labels exactly those three codes expected pre-bump and exits 0 when nothing else is found; every other code still fails. JSON additively gains `staged` and `expected_pre_bump`. Without the flag output and exit status are unchanged. Refs #227 Refs #236
chrisdpurcell
force-pushed
the
staged
branch
from
September 1, 2026 20:27
40dc101 to
a0ac48f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages check-release --staged: classifies exactlyPC-RELEASE-LEVEL,PC-RELEASE-PROJECTION,PC-RELEASE-PROJECT-VERSIONas expected pre-bump findings (reported asEXPECTED-PRE-BUMP, listed under an additiveexpected_pre_bumpJSON key) and exits 0 when nothing else is found; every other finding still fails. Without the flag, output and exit are byte-identical to before. Documented indocs/usage.md.Governing work
Supporting: #227
Acceptance coverage
.standardscatalog are now a single green check instead of a human triage.tests/package_contract/test_cli.py: staged-only-expected → 0; staged + real released-payload mutation → 1; staged + non-expected consistency finding → 1; no-flag JSON keys unchanged.Verification
tests/package_contract/test_cli.py(21 passed),tests/test_usage_doc_inventory.py(64),tests/package_contract/test_release.py(26),tests/control_plane/test_catalog_refresh.py(33); ruff format/check, basedpyright, five standards validators, prettier + markdownlint on the two docs — all exit 0. Live:check-release --root . --baseline v5.28.0 --stagedexits 0 withPC-RELEASE-LEVELlabelled expected.