fix(packages): --staged excuses only the pre-bump lag producer of PC-RELEASE-LEVEL - #246
Merged
Merged
Conversation
PC-RELEASE-LEVEL has two producers in classify_catalog_diff: the pre-bump lag (the proposed tool version has not advanced past the baseline) and a breaking default promotion without an owner-designated major, which is a genuinely forbidden transition. Keying the staged expectation on the code excused both, so --staged could exit 0 on a real release violation. The classifier now names its own lag findings through the additive CatalogDiff.pre_bump_lag, and the CLI labels exactly those plus the two single-producer consistency codes. `findings` and every rendered report are unchanged, so non-staged output stays byte-identical. docs/usage.md states the producer distinction and documents why a staged pass reads ok:true with classification:"forbidden". Refs #227 Refs #236
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correction to
check-release --staged(PR #239):PC-RELEASE-LEVELhas several producers and only the unbumped-version lag ("proposed tool release must advance beyond the released baseline") is expected mid-train. The staged expectation is now keyed on that producer via an additiveCatalogDiff.pre_bump_lag, so a breaking default promotion, a proposed-major mismatch, or a wrong bump level still exits 1 under--staged. Non-staged output is unchanged;docs/usage.mddocuments the JSON coherence rule (okis the gate,classificationthe unstaged release verdict).Governing work
Supporting: #227
Acceptance coverage
/tmp/ps529-session/reviews/review-landed.md).test_release.py(lag vs non-lag producers),test_cli.py(breaking promotion still exits 1 under--staged).Verification
tests/package_contract/test_cli.py(22),test_release.py(30),tests/test_usage_doc_inventory.py(65),tests/control_plane/test_catalog_refresh.py(33); ruff, basedpyright, five validators, prettier + markdownlint — all exit 0. Live--stagedon the tree exits 0 with the lag finding labelled expected.