Skip to content

Move release packaging and smoke tests into scripts/release/ - #2109

Merged
Kevinjohn merged 20 commits into
issue/1977-scripts-cifrom
issue/1978-scripts-release
Nov 16, 2026
Merged

Kevinjohn merged 20 commits into
issue/1977-scripts-cifrom
issue/1978-scripts-release

Conversation

@Kevinjohn

@Kevinjohn Kevinjohn commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

What and why

Release packaging and smoke tests move into scripts/release/, with the container scripts (prepare-container-runtime, published-image-state, smoke-docker-compose and companions) under scripts/release/docker/ as the issue asks. Each file moves with git mv; package scripts keep their command names, and every caller, import, ESLint allowance, workflow paths: filter and run: step, test and documentation link now uses the new path. Scripts that resolve the repository root go up one more folder. The Dockerfile runtime preparation step and the docker.yml filters and run steps use the new paths, as the issue requires. render-client-nginx was already removed by #1964, so it is not in this move.

  • Checked: the packaging (49), packaged-smoke (13) and release-validation (7) tests pass. A local release archive was built, its checksum verified, and the packaged-server smoke passed on the extracted archive. The Docker scripts were syntax-checked only; no image was built.

Decisions made without the owner

  • release-provenance.yml checks out the release tag's own files, so its smoke-test guard accepts either the old or the new path. A plain rename would make a rebuild of a release tagged before this move fail as "predates the smoke test".
  • Not changed: docker.yml's publish job also checks out the release tag, so re-publishing images for a release tagged before this move would not find scripts/release/docker/published-image-state.sh or smoke-docker-compose.mjs.

Closes #1978

Gate evidence

  • pnpm run check:changed <predecessor branch>: every step passed except the frontend suite, which timed out or hit its 1200-second cap under heavy machine load; a rerun of the suite, or the timed-out files alone, passed.
  • Pre-push check:push (format, type-check, lint): passed.
  • Validation workflow on this head: run 43945927424
  • Stack tip gate on issue/1980-scripts-shared (59ee4999b), which contains this branch: gate:all and e2e (309 tests) passed.

Merge order

#2070 → #2071 → #2072 → #2073 → #2074 → #2075 → #2076 → #2077 → #2078 → #2079 → #2080 → #2081 → #2082 → #2083 → #2084 → #2085 → #2086 → #2087 → #2088 → #2089 → #2090 → #2091 → #2092 → #2093 → #2094 → #2095 → #2096 → #2097 → #2098 → #2099 → #2100 → #2101 → #2102 → #2103 → #2104 → #2105 → #2106 → #2107 → #2108 → #2109 → #2110 → #2111 → #2112

Merge predecessor for this PR: #2108.

One linear stack; each PR targets the previous PR's branch. Every PR head from #2104 to #2112 merges into its base branch without conflict, and no pair of open PRs conflicts.

Closes #1978.

Release packaging, deployment, the packaged-server and dialog smoke tests,
the loopback proxy and the release validation gate now live together in
scripts/release/; the container runtime preparation, published image
check and Compose smoke test sit under scripts/release/docker/.
render-client-nginx was already removed by #1964, so it is not moved.

Package scripts, the gate, docker, validation and release provenance
workflow paths and run steps, the Dockerfile's runtime preparation step
and the tests that read these files follow the new paths. Repository-root
lookups gain one or two levels.

Release provenance rebuilds archives from the release tag's own tree, so
its guard now accepts the packaged-server smoke test at either the new
or the old path; tags cut before this move still rebuild. Command names
and publication triggers are unchanged.

Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Closes #1979.

The DCO, Dependabot, Gitleaks and UI primitive checks, the shadcn
registry wrapper, the major dependency report and the Sonner CSP test
now live together in scripts/maintenance/, with the DCO ratifications
beside their check and the Sonner import probe in fixtures/. Package
scripts, the gate workflow's sign-off step, the Gitleaks configuration
comment and the selector test fixtures follow the new paths;
repository-root lookups and the UI check's parse of the registry
working directory gain one level. Command names and behaviour are
unchanged.

Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Closes #1980.

The pnpm spawn helper, its declarations and its test now live in
scripts/shared/. Every importer follows the new path: the preset and
browser runners, the selector, gate runner and pre-push hook, the
Paraglide parity check, the maintenance and end-to-end scripts, the
frontend test and the end-to-end global setup. The preset path test
copies the helper into the same folder layout. Command names and
behaviour are unchanged.

Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
…ntenance

Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
…-shared

Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Closes #2028. docs/ is removed from the index and ignored. The Pages
workflow builds the site in its own run before uploading it; the docs
workflow keeps the build and navigation check and runs the image
lightbox test against the built site through a new docs:test script,
since that test reads docs/. The frontend suite skips that file unless
docs:test runs it. check:changed builds and checks the site instead of
comparing a committed copy. AGENTS.md, CONTRIBUTING.md, README.md, the
PR template, the CodeQL path filter and the OpenSSF answer no longer
describe a committed site; `pnpm run docs:build` still produces the
offline copy in docs/.

Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
…ntenance

Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
…-shared

Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
…ing-docs

Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
@Kevinjohn Kevinjohn added the polish-in-progress Polish review running label Nov 16, 2026
The open-source page still told contributors to rebuild the committed site
before opening a pull request. docs/ is no longer committed, so the page now
asks for a passing docs:build and sources only, and a documentation policy
test keeps contributor guidance from asking for a committed site again.

Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
The default frontend suite excludes the lightbox test because it reads the
built site. check:changed still passed a changed copy of it to vitest as a
frontend test file: --static then failed with no test files found, and the
full check ran vitest related, which matched nothing and passed without
running it. A change to that test now selects the docs build and docs:test
steps instead.

Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
@Kevinjohn

Copy link
Copy Markdown
Owner Author

Polish review

Findings: none at P1 or P2.

Verified for this move (repository facts at 5f7b0e34f):

  • The Dockerfile change is the one runtime-preparation path, and docker.yml changes only its paths: filters and the script paths in its run: steps; both are what Move release packaging and smoke tests into scripts/release/ #1978 asks for. No image was built or run.
  • gate.yml paths: filters, release-provenance.yml and validation.yml use scripts/release/; the one remaining old path is the deliberate fallback in the release-provenance.yml smoke-test guard.
  • The validated job in release-provenance.yml checks out the workflow's own ref, so a manual run from main finds scripts/release/require-release-validation.mjs.
  • The Docker tests read Dockerfile, Compose and docker.yml three levels up from scripts/release/docker/.

Mechanical proof of the move (repository facts at the PR head, range against the predecessor's head):

  • Every moved file is a git rename; files below 100% similarity differ only in path lines (relative imports, import.meta.url root lookups and path literals), checked line by line in the rename diffs.
  • No tracked file outside CHANGELOG-ARCHIVE.md names an old path: a word-bounded search of the tree for each old path found none.
  • Every relative import, import() and new URL(..., import.meta.url) specifier in tracked JavaScript and TypeScript resolves, with the same five pre-existing unresolved build-output or runtime targets as the predecessor head.
  • Every Markdown link and every scripts/... path in tracked Markdown, workflow, TOML and JSON files resolves, the same as on the predecessor head.
  • Each relative-root lookup in a moved file gained exactly one .. per added folder level.

Checks

Merge predecessor: #2108.

@Kevinjohn Kevinjohn added polish-done Polish review complete and removed polish-in-progress Polish review running labels Nov 16, 2026
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
…ntenance

Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
…-shared

Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
…ing-docs

Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Stop committing the generated documentation site
Move the shared pnpm process helper into scripts/shared/
Move repository maintenance checks into scripts/maintenance/
@Kevinjohn
Kevinjohn merged commit d317808 into issue/1977-scripts-ci Nov 16, 2026
2 checks passed
@Kevinjohn
Kevinjohn deleted the issue/1978-scripts-release branch November 16, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

polish-done Polish review complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant