Repository navigation
Move application build tooling into scripts/build/ - #2106
Merged
Merged
Conversation
Closes #1975. The bundle budget, SPA route checks, Paraglide parity check, static route list and the Adonis public sync now live together in scripts/build/. The sync script and parity check resolve the repository root one level higher; the budget and route checks keep reading dist/ from the working directory. Package scripts, workflow build steps, frontend imports, ESLint allowances and the tests that read or copy these files follow the new paths. Command names and behaviour are unchanged. Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Closes #1976. The Playwright run mode, worker runtime and guardian, preset and browser runners, the production rehearsal server and their tests now live together in scripts/e2e/; browser scenarios stay in e2e/. Playwright config, the end-to-end type-check project, frontend and backend tests, ESLint allowances, the port guard's file list and package scripts follow the new paths. The changed-file selector's end-to-end input pattern now matches scripts/e2e/playwright*, and the preset path test copies its files into the same folder layout. Command names and behaviour are unchanged. Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Closes #1977. The changed-file selector, gate runner and command list, pre-push hook, Node 26 check and workflow outcome report now live together in scripts/ci/, and the gate command fixture moves to scripts/ci/fixtures/. The Git hook, package scripts, workflow run steps (including the tooling and static scope selection in gate.yml and static-analysis.yml) and CONTRIBUTING.md follow the new paths, and repository-root lookups gain one level. The selector now matches script files in any scripts/ subfolder and finds the test files that import a script by their relative path, so a change to a moved script still selects its tests. Its fixtures name the moved paths. Command names are unchanged. Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Closes #1978. Release packaging, deployment, the packaged-server and dialog smoke tests, the loopback proxy and the release validation gate now live together in scripts/release/; the container runtime preparation, published image check and Compose smoke test sit under scripts/release/docker/. render-client-nginx was already removed by #1964, so it is not moved. Package scripts, the gate, docker, validation and release provenance workflow paths and run steps, the Dockerfile's runtime preparation step and the tests that read these files follow the new paths. Repository-root lookups gain one or two levels. Release provenance rebuilds archives from the release tag's own tree, so its guard now accepts the packaged-server smoke test at either the new or the old path; tags cut before this move still rebuild. Command names and publication triggers are unchanged. Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Closes #1979. The DCO, Dependabot, Gitleaks and UI primitive checks, the shadcn registry wrapper, the major dependency report and the Sonner CSP test now live together in scripts/maintenance/, with the DCO ratifications beside their check and the Sonner import probe in fixtures/. Package scripts, the gate workflow's sign-off step, the Gitleaks configuration comment and the selector test fixtures follow the new paths; repository-root lookups and the UI check's parse of the registry working directory gain one level. Command names and behaviour are unchanged. Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Closes #1980. The pnpm spawn helper, its declarations and its test now live in scripts/shared/. Every importer follows the new path: the preset and browser runners, the selector, gate runner and pre-push hook, the Paraglide parity check, the maintenance and end-to-end scripts, the frontend test and the end-to-end global setup. The preset path test copies the helper into the same folder layout. Command names and behaviour are unchanged. Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com> # Conflicts: # scripts/e2e/e2eReset.test.mjs
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
…ntenance Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
…-shared Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Closes #2028. docs/ is removed from the index and ignored. The Pages workflow builds the site in its own run before uploading it; the docs workflow keeps the build and navigation check and runs the image lightbox test against the built site through a new docs:test script, since that test reads docs/. The frontend suite skips that file unless docs:test runs it. check:changed builds and checks the site instead of comparing a committed copy. AGENTS.md, CONTRIBUTING.md, README.md, the PR template, the CodeQL path filter and the OpenSSF answer no longer describe a committed site; `pnpm run docs:build` still produces the offline copy in docs/. Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
This was referenced Nov 16, 2026
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
…ntenance Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
…-shared Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
…ing-docs Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
The open-source page still told contributors to rebuild the committed site before opening a pull request. docs/ is no longer committed, so the page now asks for a passing docs:build and sources only, and a documentation policy test keeps contributor guidance from asking for a committed site again. Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
The default frontend suite excludes the lightbox test because it reads the built site. check:changed still passed a changed copy of it to vitest as a frontend test file: --static then failed with no test files found, and the full check ran vitest related, which matched nothing and passed without running it. A change to that test now selects the docs build and docs:test steps instead. Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Owner
Author
Polish reviewUnfixed P1: the Docker image build loses
Verified for this move (repository facts at
Mechanical proof of the move (repository facts at the PR head, range against the predecessor's head):
Checks
Merge predecessor: #2105. |
Part of #1975. The .dockerignore rule **/build also matched the new scripts/build/ folder, so the image's pnpm run build would not find the build tooling it runs. Re-include that folder; other build output stays excluded. Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
…ntenance Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
…-shared Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
…ing-docs Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Stop committing the generated documentation site
Move the shared pnpm process helper into scripts/shared/
Move repository maintenance checks into scripts/maintenance/
Move release packaging and smoke tests into scripts/release/
Move CI selection, gates and reporting into scripts/ci/
Move browser-test infrastructure into scripts/e2e/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Application build tooling moves into
scripts/build/: the bundle budget, SPA route-document check, Paraglide plugin parity, static SPA routes and the sync to the backend's public folder. Each file moves withgit mv; package scripts keep their command names, and every caller, import, ESLint allowance, workflowpaths:filter andrun:step, test and documentation link now uses the new path. Scripts that resolve the repository root go up one more folder.pnpm run buildpasses, including the bundle and route checks and the public-folder sync; the Paraglide parity check passes.Decisions made without the owner
.dockerignorere-includesscripts/build/(126901e9e). Its**/buildrule, meant for build output, also matched the new folder, so the image'spnpm run buildwould have lost the build tooling it runs. A.dockerignorematcher run over every tracked file underscripts/reported 8 of the moved files excluded before the fix and none after; the set of scripts in the Docker context now matchesmain, andapps/*/buildoutput stays excluded. No image was built.AGENTS.mdrestricts Dockerfiles, Compose, Docker workflows and Docker tests; this ignore-file line keeps the existing image build working after the move.Closes #1975
Gate evidence
pnpm run check:changed <predecessor branch>: passed.check:push(format, type-check, lint): passed.issue/1980-scripts-shared(59ee4999b), which contains this branch:gate:allande2e(309 tests) passed.Merge order
#2070 → #2071 → #2072 → #2073 → #2074 → #2075 → #2076 → #2077 → #2078 → #2079 → #2080 → #2081 → #2082 → #2083 → #2084 → #2085 → #2086 → #2087 → #2088 → #2089 → #2090 → #2091 → #2092 → #2093 → #2094 → #2095 → #2096 → #2097 → #2098 → #2099 → #2100 → #2101 → #2102 → #2103 → #2104 → #2105 → #2106 → #2107 → #2108 → #2109 → #2110 → #2111 → #2112
Merge predecessor for this PR: #2105.
One linear stack; each PR targets the previous PR's branch. Every PR head from #2104 to #2112 merges into its base branch without conflict, and no pair of open PRs conflicts.