Flight Tracker app icon (custom app.png via ClassicyIcons registry)#175
Merged
Conversation
…s.flightTracker
app.png was a TIFF with a .png name (browsers won't render TIFF) — converted
to real 32x32 PNG. Registered with registerClassicyIcons, spreading the
existing applications namespace (registration assigns shallowly). Both
ClassicyWindows now carry icon={appIcon}.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019NMS1V2keS3pTbWRemCd9o
|
✅ Playwright E2E — 1 passed · 0 failed · 0 flaky · 0 skipped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the borrowed
ClassicyIcons.controlPanels.location.appicon with the app's ownapp.png, registered atClassicyIcons.applications.flightTracker.appvia classicy'sregisterClassicyIconshook.<img>, so it's converted in place to a real 32×32 RGBA PNG.registerClassicyIconsassigns shallowly, so the existingapplicationsnamespace is spread in to keep classicy's bundled app icons (epg, internetExplorer, …) intact.ClassicyWindows (flight-map,flight-settings) now passicon={appIcon}so the title bars show it too.registerClassicyIcons, and a new case asserts every window receives the app.png icon. Gates: tsc, eslint, 374 tests green.🤖 Generated with Claude Code
https://claude.ai/code/session_019NMS1V2keS3pTbWRemCd9o