Skip to content

imreview: state the preflight-failure behavior explicitly (#53) #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tzhouam merged 2 commits into from
Aug 25, 2026
Merged

imreview: state the preflight-failure behavior explicitly (#53) #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3729b38
imreview: state the preflight-failure behavior explicitly
tzhouam Aug 25, 2026
2ec5521
Merge branch 'main' into fix/imreview-preflight-failure-explicit
tzhouam Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion integrations/cursor/imreview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ Before pytest, run a short import/version compatibility preflight. Bind every
validation command and result to the head SHA and an environment fingerprint;
reuse an environment only when its dependency fingerprint matches. After the
preflight passes, run targeted tests and low-cost static checks alongside the
source review.
source review. If the preflight fails, skip tests, continue the source review,
and record the skipped validation as an explicit verification gap in the final
report.
Stop when every changed semantic path has a supported finding or an explicit
no-issue conclusion; do not add searches only for confidence.
After source review independently verifies and freezes its candidate findings,
Expand Down
4 changes: 3 additions & 1 deletion plugins/infermatrix-copilot/skills/imreview/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ Before pytest, run a short import/version compatibility preflight. Bind every
validation command and result to the head SHA and an environment fingerprint;
reuse an environment only when its dependency fingerprint matches. After the
preflight passes, run targeted tests and low-cost static checks alongside the
source review.
source review. If the preflight fails, skip tests, continue the source review,
and record the skipped validation as an explicit verification gap in the final
report.
Stop when every changed semantic path has a supported finding or an explicit
no-issue conclusion; do not add searches only for confidence.
After source review independently verifies and freezes its candidate findings,
Expand Down
4 changes: 4 additions & 0 deletions test/test_imreview_output_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ def test_imreview_returns_github_style_findings(prompt_path: Path) -> None:
assert "before reading knowledge, searching source, or running tests" in prompt
assert "bounded `rg` searches" in prompt
assert "import/version compatibility preflight" in prompt
assert (
"If the preflight fails, skip tests, continue the source review, "
"and record the skipped validation as an explicit verification gap"
) in prompt
assert "head SHA and an environment fingerprint" in prompt
assert "at the pinned head SHA" in prompt
assert "fetch the PR head ref" in prompt
Expand Down
Loading