imreview: state the preflight-failure behavior explicitly (#53) - #101
Merged
Conversation
The skill mandates an import/version compatibility preflight before pytest but never said what happens when it fails on a non-docs change. Say it: skip tests, keep reviewing source, and record the skipped validation as an explicit verification gap in the final report. Both prompt copies updated, and the output-contract test pins the sentence. Closes #53. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0165QsXAeLVPrKfj8Yk5zns3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One sentence added to the imreview prompt (both synced copies): when the import/version
compatibility preflight fails on a non-docs change, skip tests, continue the source
review, and record the skipped validation as an explicit verification gap in the final
report.
Why
#53 reported the default review running ut/e2e in an environment that cannot run them
(Windows). The behavior was already implied by "run targeted tests after the preflight
passes", but the failure branch was never stated, so hosts could reasonably block or
retry instead of degrading gracefully. This makes the existing design explicit; tests stay
default-on where the environment supports them (per the maintainer's comment in #53).
Files
plugins/infermatrix-copilot/skills/imreview/SKILL.mdintegrations/cursor/imreview.md(synced copy)test/test_imreview_output_contract.py— pins the new sentence in both copiesVerification
pytest test/test_imreview_output_contract.py— greenCloses #53.
🤖 Generated with Claude Code
https://claude.ai/code/session_0165QsXAeLVPrKfj8Yk5zns3