Repository navigation
Conversation
shlyaeva
approved these changes
Nov 9, 2026
Contributor
Author
|
As @hga007 points out https://github.com/JCSDA-internal/oops/pull/3456#issuecomment-6717476563, this PR is migrating certain implementations from oops into soca (and other models) with minimal change. It may be desirable to rewrite some of these implementations to include the land-sea mask. If so, I would advocate for doing it in a separate PR, to separate the migration from the algorithm change. |
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion to https://github.com/JCSDA-internal/oops/pull/3456
Issue(s) addressed
Toward https://github.com/JCSDA-internal/oops/issues/3450
Dependencies
build-group=https://github.com/JCSDA-internal/oops/pull/3456
build-group=https://github.com/JCSDA-internal/fv3-jedi/pull/1567
build-group=https://github.com/JCSDA-internal/mpas-jedi/pull/1260
build-group=https://github.com/JCSDA-internal/pyiri-jedi/pull/220
Impact
Checklist