Repository navigation
Add State::addFields and State::removeFields - #1271
Merged
fmahebert merged 2 commits intoNov 12, 2026
Merged
Conversation
SamuelDegelia-NOAA
requested review from
fmahebert,
guillaumevernieres and
shlyaeva
November 2, 2026 17:46
shlyaeva
approved these changes
Nov 3, 2026
…into feature/add_update_fields
SamuelDegelia-NOAA
changed the base branch from
develop
to
feature/ensemble_da_interfaces
November 12, 2026 20:19
Contributor
|
I'm merging this into #1275 — both PRs are expanding the interfaces in support of Kalman filter applications, and combining the PRs will reduce back-to-back coordinated merges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
State::removeFields(vars)andState::addFields(vars)as wrappers around the existingState::updateFields. OOPS will soon require these two methods from every model State (JCSDA-internal/oops#3420). An in-development PR for L/GETKF uses them to reduce peak memory (JCSDA-internal/oops#3354). Note thatupdateFieldsitself is unchanged so that existing behavior is not affected.Issue(s) addressed
N/A
Dependencies
Should merge before or alongside JCSDA-internal/oops#3420.
Impact
None. The new methods are only called by OOPS once JCSDA-internal/oops#3420 merges.
Checklist