NRCL-28 Prepare neural-sdk 0.4.2 contact hotfix - #22
Conversation
|
Linked to Plane Work Item(s) References This comment was auto-generated by Plane |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7aa6c856f5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4377a42b7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e54f9eca3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c2c436db5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Problem
PyPI
neural-sdk0.4.1 publishescontributors@neural-sdk.dev, and public documentation usessupport@neural-sdk.com. Both domains were found unregistered during the contact-security audit, creating expired-domain takeover and maintainer-impersonation risk.The public 0.4.1 release line diverges from
main. Applying the main-based fix directly would change the public package payload and dependency surface beyond this security hotfix.Outcome
This release-line candidate:
intelip.cocontacts;tomlicompatibility fallback;Acceptance Criteria
neural-sdk.devorneural-sdk.com, including mixed-case variants.hudson@intelip.co.Validation
Exact base:
9b80b424c34e25f86fb8280bd099e7473318ccde(v0.4.1release commit)Exact candidate:
585747cc9795d37e7e8b04d234f3e7955bc49153Passed on exact candidate:
neural/_version.pychanged from public 0.4.1;Hosted artifacts:
9a63b05f2228262327e374c6282f6ae818eccb93c2400f79a91903d31a13925c2988c5db0214493078469b12ebb85da543dc32b650eb18d68cd63a786b252561Review Findings Addressed
Residual Risk
The absolute repository Black gate remains failed by six untouched files inherited from 0.4.1. Changed Python files pass Black, and this candidate introduces no new formatting regression.
This PR intentionally targets the published 0.4.1 release branch, not
main. Broader source-line reconciliation remains separate work.Pinned first-party actions currently emit non-blocking Node 20 deprecation annotations under GitHub's Node 24 forced runtime. Default-branch Dependabot debt remains separate.
One excluded hosted run (
30060702867) used a mistyped nonexistent SHA and failed checkout; it is not candidate evidence. Run30060718450is the exact-head evidence.Release Safety and Exclusions
Plane work item:
NRCL-28/NV-002.Merge approval does not authorize tag creation, TestPyPI/PyPI publication, deployment, DNS changes, billing, infrastructure, secrets, or live-money actions. Publication remains a separate explicit gate.