NRCL-64 Register trusted release candidate validation - #23
Conversation
📚 Documentation Statusℹ️ No documentation-related changes detected This comment is automatically generated by the documentation workflow. |
|
Linked to Plane Work Item(s) References This comment was auto-generated by Plane |
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3f423131b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| from packaging.version import InvalidVersion, Version | ||
|
|
||
| _COMMIT_SHA = re.compile(r"^[0-9a-f]{40}$") | ||
| _BLOCKED_DOMAINS = tuple(f"neural-sdk.{suffix}".encode("ascii") for suffix in ("dev", "com")) |
There was a problem hiding this comment.
Avoid blocking current candidates on existing docs domains
When candidate_sha points at this branch/main as it stands, this blanket substring block makes validate-source fail before artifact validation because the repo still contains neural-sdk.dev/neural-sdk.com in public files such as pyproject.toml, CONTRIBUTING.md, CODE_OF_CONDUCT.md, and the OpenAPI docs. I verified the new validator exits with those violations, so the registered workflow cannot validate the exact current candidate unless unrelated docs/contact strings are changed or the scan is narrowed to the unsafe contact surfaces intended here.
Useful? React with 👍 / 👎.
Problem
Neural's release dry-run workflow exists only on the divergent 0.4.1 lineage. GitHub registers manually dispatchable workflows from the default branch, so PR #22's exact-head dry run returns HTTP 404 even though its candidate workflow file supports
workflow_dispatch.Outcome
This PR adds a default-branch-owned, non-publishing release-candidate validation harness that:
validatedartifacts only after both install smokes pass;tomlicompatibility fallback.Plane: NRCL-64 / NV-003.
Acceptance Criteria
main.7aa6c856f5ad18b42375254fe8b52bc50cc868d4.Validation
Exact base:
3c4621cecb2c6efc83cf91aa6d9cf17f815bb311Exact candidate:
d3f423131ba5e733e6c202186f550f5eb1d9b331Passed on exact candidate:
git diff --check;uv lock --check;Residual Risk
GitHub cannot execute this new workflow as a registered
workflow_dispatchworkflow until it is merged to the default branch. Merge remains separately approval-gated. After merge, dispatch must use--ref mainwith PR #22's immutable SHA ascandidate_sha.The default branch currently reports separate Dependabot debt. This PR adds only the Python 3.10 development compatibility declaration and does not claim broader dependency remediation.