Skip to content

feat(combo-templates): update combo templates topics - #1040

Merged
ChronosSF merged 6 commits into
vnextfrom
hhristov/update-combo-templates-topics
Nov 16, 2026
Merged

ChronosSF merged 6 commits into
vnextfrom
hhristov/update-combo-templates-topics

Conversation

@Hristo313

Copy link
Copy Markdown
Contributor

Closes #723

Update the Combo Template xplat topics

Also updated the samples:
Angular -> IgniteUI/igniteui-angular-samples#4077
React -> IgniteUI/igniteui-react-examples#1141
WC -> IgniteUI/igniteui-wc-examples#1312
Blazor -> IgniteUI/igniteui-blazor-examples#1360

Checklist:

  • check topic's TOC/menu and paragraph headings
  • Include TOC topic labels in the topic content when it has a valuable update, is new, or is considered preview / beta
  • link to other topics using ./page.mdx or ../relative/path.mdx (.mdx extension required)
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check if links function by running the check-api/mdx npm commands
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo
  • add or update meaningful llms.description metadata and run npm run check:llms-metadata


  • do not resolve requested changes (leave that to the reviewer)

@DiLazarova

Copy link
Copy Markdown
Contributor

Review for Combo Templates - React/ Chrome

  1. Live Demo: first when loading the page there should be no selection and the dropdown should be open:
Screenshot 2026-11-11 at 14 26 44
  1. The Dropdown should be open so that the user going through all the templates, can see how they are displayed:
Screenshot 2026-11-11 at 14 30 41
  1. The Combo component should be in the center of the Sample Viewer Frame
Screenshot 2026-11-11 at 14 39 36

4. Please double check for hardcoded colors and text styles!

  • There are hardcoded text in the Header template - "Destinations by region" and "Select all" should be as follows: Destinations by region - subtitle 2 - 14/24 (relevant for each theme), Select all - other/button 14/16
  • In Footer template - "2 selected" and "Clear" - should be Body2- 14/20 and other/button 14/16
  • "Selection" panel, title and list - should be subtitle 2 and body 2 for Material - Titilium font and the relevant fonts for other themes

@ChronosSF ChronosSF added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 16, 2026
@ChronosSF ChronosSF self-assigned this Nov 16, 2026
ChronosSF and others added 3 commits November 16, 2026 16:00
# Conflicts:
#	docs/angular/src/content/en/components/combo.mdx
vnext (#936) removed the Angular-only themes/misc/tailwind-classes.mdx;
themes/tailwind.mdx now serves Angular, React, Web Components and Blazor.
The combo overview and single selection topics still sent Angular to the
removed page.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ChronosSF ChronosSF added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Nov 16, 2026
@ChronosSF
ChronosSF merged commit 6ed1903 into vnext Nov 16, 2026
17 checks passed
@ChronosSF
ChronosSF deleted the hhristov/update-combo-templates-topics branch November 16, 2026 15:25
ChronosSF added a commit that referenced this pull request Nov 16, 2026
…ar links

With #1040 in, the Angular Combo topics all come from the xplat source, so
the Features topic can serve Angular too.

- toc.json: remove the Angular exclusion that #1040 put on Features; it is
  what kept features.mdx from being generated for Angular, and the Angular
  toc entry from resolving.
- overview, single-selection, templates: point the Angular links to the
  removed combo-features and combo-remote pages at ./features.mdx and its
  #remote-binding section.
- features: point the remote-binding note at ./overview.mdx#data-binding,
  and replace the per-platform Additional Resources lists, identical once
  the Angular links moved, with one shared list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

combo doc-redesign status: ✔️ by-design ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inputs/combo/templates.mdx

3 participants