Skip to content

feat(combo): update features topic content - #1032

Merged
ChronosSF merged 13 commits into
vnextfrom
iminchev/update-combo-features-topic
Nov 16, 2026
Merged

ChronosSF merged 13 commits into
vnextfrom
iminchev/update-combo-features-topic

Conversation

@IMinchev64

Copy link
Copy Markdown
Contributor

Closes #720

Checklist:

  • check topic's TOC/menu and paragraph headings
  • Include TOC topic labels in the topic content when it has a valuable update, is new, or is considered preview / beta
  • link to other topics using ./page.mdx or ../relative/path.mdx (.mdx extension required)
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check if links function by running the check-api/mdx npm commands
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo
  • add or update meaningful llms.description metadata and run npm run check:llms-metadata


  • do not resolve requested changes (leave that to the reviewer)

@DiLazarova

Copy link
Copy Markdown
Contributor

Review "Combo features" for Angular

When switching to the “Material” theme, the Combo component appears incorrectly:
Screenshot 2026-11-16 at 11 40 44
Screenshot 2026-11-16 at 11 35 42

@DiLazarova

Copy link
Copy Markdown
Contributor

Add the info banner in the Live Demo Section, similar to Combo Templates Live Demo examples:
Screenshot 2026-11-16 at 12 04 07

@DiLazarova

DiLazarova commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

There is no such button in Bootstrap theme:
Screenshot 2026-11-16 at 12 11 02
Flat Button - Bootstrap - Dark mode:
Screenshot 2026-11-16 at 12 38 37
Button Handoff
NB! Check to see if Sample uses the correct flat button in each theme, as well as for light and dark modes!

@DiLazarova

Copy link
Copy Markdown
Contributor

Custom Overlay Settings Section:

The Combo Dropdown overlaps the input in Fluent and Bootstrap for both light and dark mode:
Screenshot 2026-11-16 at 12 49 18
Screenshot 2026-11-16 at 12 49 26

@ChronosSF ChronosSF left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remote scenarios should be added for React too as the React release is simultaneous. There should already be a beta from WC 7.5.

Comment thread docs/xplat/src/content/en/toc.json Resolved
@IMinchev64

Copy link
Copy Markdown
Contributor Author

@ChronosSF The Angular build and the relative-links check fail because the Angular combo features page isn’t generated until IgniteUI/igniteui-documentation#1040 · feat(combo-templates): update… is merged. I’ll update this branch once it’s in.

ChronosSF and others added 2 commits November 16, 2026 17:30
# Conflicts:
#	docs/angular/src/content/en/components/combo-features.mdx
#	docs/angular/src/content/en/components/combo-remote.mdx
#	docs/angular/src/content/en/components/combo-templates.mdx
#	docs/angular/src/content/en/components/combo.mdx
#	docs/angular/src/content/en/components/simple-combo.mdx
…ar links

With #1040 in, the Angular Combo topics all come from the xplat source, so
the Features topic can serve Angular too.

- toc.json: remove the Angular exclusion that #1040 put on Features; it is
  what kept features.mdx from being generated for Angular, and the Angular
  toc entry from resolving.
- overview, single-selection, templates: point the Angular links to the
  removed combo-features and combo-remote pages at ./features.mdx and its
  #remote-binding section.
- features: point the remote-binding note at ./overview.mdx#data-binding,
  and replace the per-platform Additional Resources lists, identical once
  the Angular links moved, with one shared list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@DiLazarova

Copy link
Copy Markdown
Contributor

The banner should have the same styles for all 4 themes
Screenshot 2026-11-16 at 18 08 19

@ChronosSF
ChronosSF enabled auto-merge November 16, 2026 16:43
@ChronosSF
ChronosSF self-requested a review November 16, 2026 16:43
@ChronosSF ChronosSF added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Nov 16, 2026
@ChronosSF
ChronosSF disabled auto-merge November 16, 2026 16:48
@ChronosSF
ChronosSF merged commit 7a2e626 into vnext Nov 16, 2026
17 checks passed
@ChronosSF
ChronosSF deleted the iminchev/update-combo-features-topic branch November 16, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inputs/combo/features.mdx

3 participants