MAINT: update to latest cogent3 - #74
Merged
Merged
Conversation
[CHANGED] and bump version to 2025.7.17
Reviewer's GuideThis PR modernizes the codebase for the latest cogent3 API by replacing custom loading utilities with cogent3 loaders, updating imports and API calls across production code and tests, and bumping the package version and dependency spec Class diagram for updated sequence loading in aln_to_counts.pyclassDiagram
class align_to_counts {
+direction
+chosen_base
+orig_seqs
+seqs
+just_nucs(seqs)
}
class cogent3 {
+load_aligned_seqs(path, moltype)
}
align_to_counts --> cogent3 : uses load_aligned_seqs
Class diagram for removal of load_from_fasta utilityclassDiagram
class util {
-load_from_fasta(filename)
+array_to_str(data)
}
class cogent3 {
+load_aligned_seqs(path, moltype)
}
util ..> cogent3 : replaced by load_aligned_seqs
Class diagram for motif_count.py cogent3 API updateclassDiagram
class motif_count {
+profile_to_seq_counts(data, flank_size)
+dna_alpha
}
class cogent3 {
+get_moltype(type)
+make_table(...)
}
motif_count --> cogent3 : uses get_moltype, make_table
Class diagram for log_lin.py Table import updateclassDiagram
class log_lin {
+Table
}
class cogent3_core_table {
+Table
}
log_lin ..> cogent3_core_table : imports Table
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @GavinHuttley - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[CHANGED] and bump version to 2025.7.17
Summary by Sourcery
Migrate the codebase to the latest cogent3 API, update imports and function calls accordingly, adjust tests for removed parameters, and bump the package version and dependency requirement.
Bug Fixes:
Enhancements:
Build:
Tests:
Chores: