ci(nightly-judge): stop republishing stale verdicts on failed runs - #254
Merged
Conversation
The judge step needs GOOGLE_GENERATIVE_AI_API_KEY and fails honestly without it, but the following upload step ran with if: always() and shipped the git-tracked docs/eval/gemini-media-judges/ folder as a per-run artifact. Every one of the 37 scheduled failures since 2026-08-05 therefore published the committed verdicts from 2026-07-04 as if they had just been produced. Upload only after a successful judge run. The missing-key failure itself stays red and unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Scaffold Handoff — For Your Coding Agent
Immutability CheckMode: advisory This is advisory because the check is not running in strict scaffold-repair mode. Immutable files guarded during scaffold repair:
Changed Files
Needs Adversarial Review — Do NOT Apply YetThese proposals passed the reject check but have not been approved by
Safety Boundary
Immutable files (never modify):
Scaffold files (safe to modify):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A maintainer downloading the nightly-judge artifact expects verdicts the judge just produced. The judge step needs
GOOGLE_GENERATIVE_AI_API_KEY, which is absent from this repo's Actions secrets, so it fails honestly on every scheduled run (37 of 37 since 2026-08-05). The upload step then ran underif: always()and shipped the git-trackeddocs/eval/gemini-media-judges/folder (last changed 2026-07-04) as a fresh per-run artifact. This change uploads only after a successful judge run.Not changed: the judge still fails red without the key. Whether to provision the key (Gemini spend on every nightly run) or leave the lane NOT_RUN is an owner decision recorded in the portfolio ledger.
🤖 Generated with Claude Code