Skip to content

fix(deps): move Tiptap to 3.31.3 and clear the ReDoS and provider-utils advisories - #255

Merged
HomenShum merged 1 commit into
mainfrom
fix/deps-tiptap-redos-advisory
Sep 11, 2026
Merged

fix(deps): move Tiptap to 3.31.3 and clear the ReDoS and provider-utils advisories#255
HomenShum merged 1 commit into
mainfrom
fix/deps-tiptap-redos-advisory

Conversation

@HomenShum

Copy link
Copy Markdown
Owner

Every NodeRoom PR now fails the production gate at its first step, npm audit --omit=dev --audit-level=moderate, because two advisories were published after main's last green run on 2026-09-05: GHSA-j95f-988m-3j2f (quadratic ReDoS in Tiptap's Markdown attribute parsing, fixed in 3.30.5) hits all 30 @tiptap/* packages pinned at ^3.30.4, and GHSA-866g-f22w-33x8 (@ai-sdk/provider-utils < 4.0.33) hits the ai-sdk providers. Seen first on #254's verify job (run 34578853729: 35 vulnerabilities, 29 high).

Tiptap packages pin exact peer versions among themselves, so the family has to move together: all six direct pins go to ^3.31.3 and the lockfile resolves the 30 packages at 3.31.3 with no invalid peers. The ai-sdk providers move within their existing caret ranges via npm audit fix. Result: npm audit --omit=dev reports 0 vulnerabilities.

Local floor: root and Convex typechecks clean; vitest 2779/2780 on the full run, with one temp-directory flake in spreadsheetBenchRunner.test.ts that passes 29/29 in isolation. The editor surfaces get their real check from this PR's CI (prod:gate, proofloop-gate, packed consumer).

🤖 Generated with Claude Code

…ls advisories

npm audit (the first step of prod:gate) began failing on every PR: GHSA-j95f-988m-3j2f
(quadratic ReDoS in Tiptap Markdown attribute parsing, fixed in 3.30.5) reached all 30
@tiptap packages pinned at ^3.30.4, and GHSA-866g-f22w-33x8 (uncontrolled resource
consumption in @ai-sdk/provider-utils < 4.0.33) reached the ai-sdk providers. Tiptap
packages pin exact peer versions among themselves, so the whole family moves together to
3.31.3; the ai-sdk providers move within their existing caret ranges. npm audit
--omit=dev now reports 0 vulnerabilities; npm ls shows no invalid peers.

Local floor: root and Convex typechecks clean; vitest 2779/2780 in the full run with
one temp-directory flake in spreadsheetBenchRunner that passes 29/29 in isolation.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
noderoom Ready Ready Preview Sep 11, 2026 8:57am UTC

Request Review

@github-actions

Copy link
Copy Markdown

Scaffold Handoff — For Your Coding Agent

Your coding agent (Codex, Claude Code, etc.) should apply the accepted
scaffold proposals below. Do NOT touch any immutable files.

Immutability Check

Mode: advisory

✅ No immutable files were modified in this branch.

Changed Files

  • docs/eval/OFFICIAL_BENCHMARK_READINESS.md
  • docs/eval/OFFICIAL_BENCHMARK_TASK_COVERAGE.md
  • docs/eval/OPENROUTER_CONVEX_BENCHMARK.md
  • docs/eval/agent-improvement-loop.md
  • docs/eval/agent-improvement-loop.svg
  • docs/eval/agent-improvement-loop/20260911T085639Z.json
  • docs/eval/agent-improvement-loop/latest.json
  • docs/eval/agent-workspace-sandbox-smoke.json
  • docs/eval/algorithm-artifact-smoke.json
  • docs/eval/bankertoolbench-official-contract.json
  • docs/eval/docker-sandbox-probe.json
  • docs/eval/eval-runs.jsonl
  • docs/eval/halo-convex-context-telemetry.json
  • docs/eval/halo-self-improvement-smoke.json
  • docs/eval/halo-variant-selection.json
  • docs/eval/official-benchmark-readiness.json
  • docs/eval/official-benchmark-task-coverage.json
  • docs/eval/openrouter-convex-benchmark.json
  • docs/eval/professional-catalog-proofs.json
  • docs/eval/professional-proof-ledger.json
  • docs/eval/spreadsheetbench-chart-visual-probe.json
  • docs/eval/traces/credit/20260911T085649673Z-544ef4ad_dirty.9247d74b43c1cce2/cascade-healthy.json
  • docs/eval/traces/credit/20260911T085649673Z-544ef4ad_dirty.9247d74b43c1cce2/delta-incomplete.json
  • docs/eval/traces/credit/20260911T085649673Z-544ef4ad_dirty.9247d74b43c1cce2/mapping-correct.json
  • docs/eval/traces/credit/20260911T085649673Z-544ef4ad_dirty.9247d74b43c1cce2/mapping-misbind.json
  • docs/eval/traces/credit/20260911T085649673Z-544ef4ad_dirty.9247d74b43c1cce2/summit-stressed.json
  • docs/eval/traces/ladder/20260911T085649221Z-544ef4ad_dirty.6a786a0c0e1c85b6/ladder_L1_read_scripted.json
  • docs/eval/traces/ladder/20260911T085649221Z-544ef4ad_dirty.6a786a0c0e1c85b6/ladder_L2_edit_scripted.json
  • docs/eval/traces/ladder/20260911T085649221Z-544ef4ad_dirty.6a786a0c0e1c85b6/ladder_L3_conflict_scripted.json
  • docs/eval/traces/ladder/20260911T085649221Z-544ef4ad_dirty.6a786a0c0e1c85b6/ladder_L4_blocked_scripted.json
  • docs/eval/traces/ladder/20260911T085649221Z-544ef4ad_dirty.6a786a0c0e1c85b6/ladder_L5_large_range_scripted.json
  • docs/eval/traces/ladder/20260911T085649221Z-544ef4ad_dirty.6a786a0c0e1c85b6/ladder_L6_long_horizon_scripted.json
  • docs/eval/traces/ladder/20260911T085649221Z-544ef4ad_dirty.6a786a0c0e1c85b6/ladder_L7_resume_scripted.json
  • package-lock.json
  • package.json

Needs Adversarial Review — Do NOT Apply Yet

These proposals passed the reject check but have not been approved by
an adversarial reviewer. A human or frozen LLM judge must approve them first.

  • scaf-001 (AGENTS.md): Add explicit instruction for step spreadsheetbench-runner-fixture: Step spreadsheetbench-runner-fixture failed — scaffold may need explicit instruction or evidence assertion.
  • scaf-002 (AGENTS.md): Add explicit instruction for step convex-boundaries: Step convex-boundaries failed — scaffold may need explicit instruction or evidence assertion.

Safety Boundary

Agent may improve the scaffold.
Agent may NOT weaken the proof gate.

Immutable files (never modify):

  • scripts/proofloop.mjs
  • scripts/agent-improvement-loop.ts
  • tests/harnessChangeEval.test.ts
  • .github/workflows/
  • src/eval/evalTrustPolicy.ts
  • src/eval/architectureBudget.ts
  • evals/evalStore.ts

Scaffold files (safe to modify):

  • AGENTS.md
  • CLAUDE.md
  • proofloop/scenarios/*.yaml
  • proofloop/rubrics/*.yaml
  • proofloop/subagents/*.md
  • proofloop/adapters/*.js
  • .proofloop/memory.jsonl
  • src/nodeagent/models/prompts/systemPrompt.ts

@HomenShum
HomenShum merged commit 0e6ce8a into main Sep 11, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant