refactor(Payroll): split time-off balance display out of TimeOffField#2466
Draft
krisxcrash wants to merge 2 commits into
Draft
refactor(Payroll): split time-off balance display out of TimeOffField#2466krisxcrash wants to merge 2 commits into
krisxcrash wants to merge 2 commits into
Conversation
Extracts the accrual-balance text into a standalone TimeOffTypeCell so it can render as a table "Type" column, and drops the employee prop from TimeOffField/PayoutTimeOffField in favor of a shouldVisuallyHideLabel flag. Prepares PayrollEditEmployee's Time off and Unused time off payout sections for a card/table layout (SDK-1134); further layout changes land in a follow-up PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
5 tasks
krisxcrash
marked this pull request as draft
July 23, 2026 20:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TimeOffField.tsx; the card/table layout redesign follows in a second PR based on this branch.TimeOffField/PayoutTimeOffFieldinto a newTimeOffTypeCell, so it can be rendered as a table "Type" column cell.employeeprop fromTimeOffField/PayoutTimeOffFieldin favor of an optionalshouldVisuallyHideLabelflag, and wires the existing "Time off" and "Unused time off payout" sections inPayrollEditEmployeePresentationthrough aBox/DataViewtable so the balance renders viaTimeOffTypeCellinstead of inline under the input.TimeOffField/TimeOffTypeCellare@internal-only and not exported.Test plan
npm run test -- --run src/components/Payroll/PayrollEditEmployee— 72/72 passingnpm run test -- --run(full suite) — 293 files / 3537 passing, 1 pre-existing expected-failnpx tsc --noEmitandnpx eslintclean on changed filesnpm run i18n:generate— newtimeOffColumns.type/timeOffColumns.hourskeys generated🤖 Generated with Claude Code