feat(Payroll): redesign Edit payroll UI as card/table sections#2467
Draft
krisxcrash wants to merge 3 commits into
Draft
feat(Payroll): redesign Edit payroll UI as card/table sections#2467krisxcrash wants to merge 3 commits into
krisxcrash wants to merge 3 commits into
Conversation
Renders each Edit payroll section (Regular and overtime hours, Time off, Additional earnings, Other) as a bordered Box with a DataView table, matching the design-mode reference. Overtime/Double overtime rows are hidden behind an "Add overtime" reveal button unless the employee already has non-zero overtime hours. Splits "Additional earnings" into "Additional earnings" (Bonus, Commission, Correction payment) and "Other" (Cash tips, Paycheck tips), and moves Additional earnings above Time off per design review. UI only — the per-workweek hours/earnings split (RRoP) is a separate ticket (SDK-1134). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The Edit-payroll card/table redesign gives each hours row's <tr> an
ARIA rowheader-derived accessible name equal to the row label (e.g.
"Regular Hours"), which is the same text as the input's own label.
getByLabelText matches both the row and the input, so it's ambiguous;
getByRole('spinbutton', ...) only matches the actual form control.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Boxcards withDataViewtables, matching the design-mode reference (sdk-app/src/design/components/payroll/PayrollEditEmployee/).Test plan
npm run test -- --run src/components/Payroll/PayrollEditEmployee— 70/70 passingnpm run test -- --run(full suite) — 3539/3542 passing (1 pre-existing expected-fail; 2 unrelatedCreatePayment.test.tsxfailures were full-suite timing flakiness, confirmed passing in isolation)npx tsc --noEmitandnpx eslintclean on changed filesnpm run i18n:generate— new translation keys generated (hoursColumns,addOvertimeCta,otherEarningsTitle,fixedAmountColumns)npm run storybook→ Domain/Payroll/PayrollEditEmployee) recommended before merge🤖 Generated with Claude Code