Skip to content

Use _minimizeJar.flatMap to guard toMinimize and apiJars #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Goooler merged 1 commit into from
Sep 3, 2026
+11 −3
Merged

Use _minimizeJar.flatMap to guard toMinimize and apiJars #2277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,14 +118,22 @@ public abstract class ShadowJar : Jar() {

@get:Classpath
public open val toMinimize: ConfigurableFileCollection = objectFactory.fileCollection {
_minimizeJar.map {
if (it) (_minimizeSpec.resolve(configurations.get()) - apiJars) else emptySet()
// Avoid resolving classpath files during task input snapshotting when minimization is disabled.
_minimizeJar.flatMap {
if (it) {
configurations.map { configs -> _minimizeSpec.resolve(configs) - apiJars }
} else {
project.provider { emptySet() }
Comment thread
Goooler marked this conversation as resolved.
}
}
}

@get:Classpath
public open val apiJars: ConfigurableFileCollection = objectFactory.fileCollection {
_minimizeJar.map { if (it) project.getApiJars() else emptySet<File>() }
// Avoid resolving classpath files during task input snapshotting when minimization is disabled.
_minimizeJar.flatMap {
if (it) project.getApiJars() else project.provider { emptyList() }
}
}

@get:InputFiles
Expand Down