Use _minimizeJar.flatMap to guard toMinimize and apiJars - #2277
Merged
Conversation
Goooler
changed the title
_minimizeJar.flatMap to guard toMinimize and apiJars
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change improves provider laziness without altering the enabled minimization behavior, and no code-level correctness issues were found.
Pull request overview
This PR refines the lazy wiring of minimization-related task inputs in ShadowJar so classpath-related providers aren’t realized when minimization is disabled, aligning provider chaining with Gradle’s flatMap idioms.
Changes:
- Updated
toMinimizeto use_minimizeJar.flatMap { ... }and deferconfigurationsaccess viaconfigurations.map { ... }only when minimization is enabled. - Updated
apiJarsto use_minimizeJar.flatMap { ... }to avoid nested providers and keep API jar resolution disabled when minimization is off.
File summaries
| File | Description |
|---|---|
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt | Switches minimization-related file collection inputs to flatMap to avoid unnecessary classpath resolution when minimization is disabled. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2276.